Changeset 274074 in webkit for trunk/Source/WebCore/css/CSSStyleDeclaration.cpp

Timestamp:

Mar 8, 2021, 8:57:53 AM (4 years ago)

Author:

[email protected]

Message:

Remove quirks for the no longer supported iAd Producer
​https://bugs.webkit.org/show_bug.cgi?id=222894

Reviewed by Chris Dumez.

Source/WebCore:

Remove two quirks that were only for iAd Producer, which is no longer
supported on the latest macOS operating systems.

By removing one quirk, we can also remove some indirection in CSSStyleDeclaration.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeSetterBodyDefinition):

• bindings/scripts/test/JS/JSTestCSSProperty.cpp:

(WebCore::setJSTestCSSProperty_propertySetter):

• css/CSSStyleDeclaration.cpp:

(WebCore::CSSStyleDeclaration::setNamedItem):
(WebCore::CSSStyleDeclaration::setPropertyValueInternal): Deleted.

• css/CSSStyleDeclaration.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense const):

• page/DeprecatedGlobalSettings.cpp:

(WebCore::DeprecatedGlobalSettings::setShouldRespectPriorityInCSSAttributeSetters): Deleted.
(WebCore::DeprecatedGlobalSettings::shouldRespectPriorityInCSSAttributeSetters): Deleted.

• page/DeprecatedGlobalSettings.h:

Source/WebKitLegacy/mac:

Remove two quirks that were only for iAd Producer, which is no longer
supported on the latest macOS operating systems.

• WebView/WebPreferencesDefaultValues.h:
• WebView/WebPreferencesDefaultValues.mm:

(WebKit::defaultNeedsIsLoadingInAPISenseQuirk): Deleted.

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(shouldRespectPriorityInCSSAttributeSetters): Deleted.

Source/WTF:

• Scripts/Preferences/WebPreferences.yaml:

Remove NeedsIsLoadingInAPISenseQuirk preference which only existed to enable
a quirk for iAd Producer.

File:

• trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (modified) (2 diffs)

trunk/Source/WebCore/css/CSSStyleDeclaration.cpp

@@ -213 +213 @@
 }
 
-ExceptionOr<void> CSSStyleDeclaration::setPropertyValueInternal(CSSPropertyID propertyID, String value)
-{
-    bool important = false;
-    if (DeprecatedGlobalSettings::shouldRespectPriorityInCSSAttributeSetters()) {
-        auto importantIndex = value.findIgnoringASCIICase("!important");
-        if (importantIndex && importantIndex != notFound) {
-            important = true;
-            value = value.left(importantIndex - 1);
-        }
-    }
-
-    return setPropertyInternal(propertyID, WTFMove(value), important);
-}
-
 const Settings* CSSStyleDeclaration::settings() const
 {
@@ -258 +244 @@
 
     propertySupported = true;
-    return setPropertyValueInternal(propertyID, WTFMove(value));
+    return setPropertyInternal(propertyID, WTFMove(value), false);
 }