Changeset 27448 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Nov 5, 2007, 1:27:15 PM (18 years ago)

Author:

ggaren

Message:

JavaScriptCore:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15835

Switched List implementation from a custom heap allocator to an inline
Vector, for a disappointing .5% SunSpider speedup.

Also renamed List::slice to List::getSlice because "get" is the
conventional prefix for functions returning a value through an out
parameter.

• kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Removed some redundant function calls and memory accesses.

• kjs/bool_object.cpp: (BooleanObjectImp::construct): Removed questionable use of iterator.

• kjs/list.cpp:
• kjs/list.h: New List class, implemented in terms of Vector. Two interesting differences:
  1. The inline capacity is 8, not 5. Many of the Lists constructed during a SunSpider run are larger than 5; almost none are larger than 8.

2. The growth factor is 4, not 2. Since we can guarantee that Lists aren't long-lived, we can grow them more aggressively, to avoid excessive copying.

• kjs/regexp_object.cpp: (RegExpObjectImp::construct): Removed redundant function calls.

• kjs/string_object.cpp: (KJS::StringObjectImp::construct): Removed questionable use of iterator.

• wtf/Vector.h: (WTF::::uncheckedAppend): Added a fast, unchecked version of append.

WebCore:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15835

Small adaptations to new KJS::List class.

• bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::ScheduledAction):

WebKit:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=15835

Small adaptations to new KJS::List class.

• ForwardingHeaders/kjs/value.h: Added.

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -165 +165 @@
     JSValue *curArg = thisObj;
     JSObject *curObj = static_cast<JSObject *>(thisObj);
-    ListIterator it = args.begin();
+    List::const_iterator it = args.begin();
+    List::const_iterator end = args.end();
     for (;;) {
       if (curArg->isObject() &&
@@ -183 +184 @@
         n++;
       }
-      if (it == args.end())
+      if (it == end)
         break;
       curArg = *it;
-      curObj = static_cast<JSObject *>(it++); // may be 0
+      curObj = static_cast<JSObject*>(curArg); // may be 0
+      ++it;
     }
     arr->put(exec, exec->propertyNames().length, jsNumber(n), DontEnum | DontDelete);