Changeset 27483 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Nov 6, 2007, 11:34:41 AM (18 years ago)

Author:

oliver

Message:

Replace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement in sunspider.

Reviewed by Darin

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1708 +1708 @@
     JSType t1 = v1->type();
     JSType t2 = v2->type();
-        
-    if (t1 == NumberType && t2 == NumberType)
+    const unsigned bothTypes = (t1 << 16) | t2;
+    
+    if (bothTypes == ((NumberType << 16) | NumberType))
         return jsNumber(v1->toNumber(exec) + v2->toNumber(exec));
-    else if (t1 == StringType && t2 == StringType) {
+    else if (bothTypes == ((StringType << 16) | StringType)) {
         UString value = static_cast<StringImp*>(v1)->value() + static_cast<StringImp*>(v2)->value();
         if (value.isNull())