Changeset 2753 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Nov 18, 2002, 11:57:11 PM (23 years ago)

Author:

darin

Message:

JavaScriptCore:

• reduced the creation of Value objects and hoisted the property map into Object for another gain of about 6%

• JavaScriptCore.pbproj/project.pbxproj: Made property_map.h public.
• kjs/array_object.cpp: (compareWithCompareFunctionForQSort): Don't wrap the ValueImp * in a Value just to add it to a list. (ArrayProtoFuncImp::call): Pass the globalObject directly so we don't have to ref/deref.
• kjs/function.cpp: (FunctionImp::call): Use a reference for the global object to avoid ref/deref. (GlobalFuncImp::call): Ditto.
• kjs/internal.cpp: (BooleanImp::toObject): Put the object directly into the list, don't create a Value. (StringImp::toObject): Ditto. (NumberImp::toObject): Ditto. (InterpreterImp::evaluate): Use a reference for the global object.
• kjs/internal.h: Return a reference for the global object.
• kjs/interpreter.cpp: (Interpreter::globalObject): Ditto.
• kjs/interpreter.h: Ditto.
• kjs/object.cpp: Use _prop directly in the object, not a separate pointer.
• kjs/object.h: Ditto.
• kjs/types.cpp: Added List methods that work directly with ValueImp. (List::append): Added a ValueImp version. (List::prepend): Ditto. (List::appendList): Work directly with the ValueImp's. (List::prependList): Ditto. (List::copy): Use appendList. (List::empty): Use a shared global List.
• kjs/types.h: Update for above changes.

WebCore:

• force-js-clean-timestamp: Another Object change.

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -230 +230 @@
     
     args->arguments.clear();
-    args->arguments.append(Value(*(ValueImp **)a));
-    args->arguments.append(Value(*(ValueImp **)b));
+    args->arguments.append(*(ValueImp **)a);
+    args->arguments.append(*(ValueImp **)b);
     return args->compareFunction->call(args->exec, args->globalObject, args->arguments)
         .toInt32(args->exec);
@@ -531 +531 @@
                 l.append(jObj);
                 l.append(minObj);
-                Object thisObj = exec->interpreter()->globalObject();
-                cmp = sortFunction.call(exec,thisObj, l ).toInt32(exec);
+                cmp = sortFunction.call(exec, exec->interpreter()->globalObject(), l).toInt32(exec);
             } else {
               cmp = (jObj.toString(exec) < minObj.toString(exec)) ? -1 : 1;