Changeset 275478 in webkit for trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp

Timestamp:

Apr 5, 2021, 7:33:10 PM (4 years ago)

Author:

Alan Bujtas

Message:

No need to update the list marker number during internal move (e.g. result of anonymous collapsing)
​https://bugs.webkit.org/show_bug.cgi?id=224142
<rdar://76101241>

Reviewed by Antti Koivisto.

Let's not update the marker numbers when the reason for re-parenting is "internal move"
which means the renderer's insertion point remains the same (e.g collapsing its anonymous parent).

• rendering/RenderElement.cpp:

(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):

• rendering/RenderElement.h:
• rendering/RenderFragmentContainer.cpp:

(WebCore::RenderFragmentContainer::insertedIntoTree):
(WebCore::RenderFragmentContainer::willBeRemovedFromTree):

• rendering/RenderFragmentContainer.h:
• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::insertedIntoTree):
(WebCore::RenderListItem::willBeRemovedFromTree):

• rendering/RenderListItem.h:
• rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::willBeRemovedFromTree):

• rendering/RenderMultiColumnFlow.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::insertedIntoTree):
(WebCore::RenderObject::willBeRemovedFromTree):

• rendering/RenderObject.h:
• rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

• rendering/RenderQuote.h:
• rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::insertedIntoTree):
(WebCore::RenderTableCaption::willBeRemovedFromTree):

• rendering/RenderTableCaption.h:
• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeRemovedFromTree):

• rendering/RenderTableCell.h:
• rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::insertedIntoTree):
(WebCore::RenderTableCol::willBeRemovedFromTree):

• rendering/RenderTableCol.h:
• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::willBeRemovedFromTree):

• rendering/RenderTableRow.h:
• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::willBeRemovedFromTree):

• rendering/RenderTableSection.h:
• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::insertedIntoTree):
(WebCore::RenderSVGRoot::willBeRemovedFromTree):

• rendering/svg/RenderSVGRoot.h:
• rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::attachToRenderElementInternal):
(WebCore::RenderTreeBuilder::move):
(WebCore::RenderTreeBuilder::detachFromRenderElement):

• rendering/updating/RenderTreeBuilder.h:

File:

• trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp

@@ -148 +148 @@
 }
 
-void RenderMultiColumnFlow::willBeRemovedFromTree()
+void RenderMultiColumnFlow::willBeRemovedFromTree(IsInternalMove isInternalMove)
 {
     // Detach all column sets from the flow thread. Cannot destroy them at this point, since they
@@ -155 +155 @@
     for (RenderMultiColumnSet* columnSet = firstMultiColumnSet(); columnSet; columnSet = columnSet->nextSiblingMultiColumnSet())
         columnSet->detachFragment();
-    RenderFragmentedFlow::willBeRemovedFromTree();
+    RenderFragmentedFlow::willBeRemovedFromTree(isInternalMove);
 }