Changeset 2757 in webkit for trunk/JavaScriptCore/kjs/property_map.cpp

Timestamp:

Nov 19, 2002, 10:44:25 AM (23 years ago)

Author:

darin

Message:

• another hash table fix; yields a 2% improvement on iBench JavaScript

• kjs/property_map.cpp: A few more places where we use & instead of %.

• some List changes that don't affect speed yet

• kjs/types.cpp: (List::prependList): Tighten up a tiny bit. (List::copy): Use prependList.
• kjs/types.h: Remove appendList and globalClear.

• kjs/interpreter.cpp: (Interpreter::finalCheck): Remove List::globalClear().

File:

• trunk/JavaScriptCore/kjs/property_map.cpp (modified) (7 diffs)

trunk/JavaScriptCore/kjs/property_map.cpp

@@ -111 +111 @@
             return _table[i].value;
         }
-        i = (i + 1) % _tableSize;
+        i = (i + 1) & _tableSizeHashMask;
     }
     return 0;
@@ -129 +129 @@
         if (keysMatch(name.rep, key))
             return _table[i].value;
-        i = (i + 1) % _tableSize;
+        i = (i + 1) & _tableSizeHashMask;
     }
     return 0;
@@ -153 +153 @@
     }
 
-    if (_keyCount >= _tableSize / 2)
+    if (_keyCount * 2 >= _tableSize)
         expand();
     
@@ -164 +164 @@
             return;
         }
-        i = (i + 1) % _tableSize;
+        i = (i + 1) & _tableSizeHashMask;
     }
     
@@ -179 +179 @@
     int i = hash(key);
     while (_table[i].key)
-        i = (i + 1) % _tableSize;
+        i = (i + 1) & _tableSizeHashMask;
     
     _table[i].key = key;
@@ -229 +229 @@
         if (keysMatch(name.rep, key))
             break;
-        i = (i + 1) % _tableSize;
+        i = (i + 1) & _tableSizeHashMask;
     }
     if (!key)
@@ -241 +241 @@
     // Reinsert all the items to the right in the same cluster.
     while (1) {
-        i = (i + 1) % _tableSize;
+        i = (i + 1) & _tableSizeHashMask;
         key = _table[i].key;
         if (!key)