Changeset 276002 in webkit for trunk/Source/WebCore/css/CSSGradientValue.cpp

Timestamp:

Apr 14, 2021, 11:15:53 PM (4 years ago)

Author:

[email protected]

Message:

Omit default position/angle when serializing radial & conic gradients
​https://bugs.webkit.org/show_bug.cgi?id=223892

Patch by Tim Nguyen <​[email protected]> on 2021-04-14
Reviewed by Antti Koivisto.

Test: LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html

LayoutTests/imported/w3c:

• web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt:

Source/WebCore:

• css/CSSGradientValue.cpp:

(WebCore::ConicGradientAdapter::normalizeStopsAndEndpointsOutsideRange):
(WebCore::CSSLinearGradientValue::customCSSText const):
(WebCore::CSSRadialGradientValue::customCSSText const):
(WebCore::CSSConicGradientValue::customCSSText const):

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::isCenterPosition const):

• css/CSSPrimitiveValue.h:

LayoutTests:

• fast/gradients/unprefixed-gradient-parsing-expected.txt:
• fast/gradients/unprefixed-gradient-parsing.html:
• http/wpt/css/css-images-4/conic-gradient-parsing.html:

File:

• trunk/Source/WebCore/css/CSSGradientValue.cpp (modified) (4 diffs)

trunk/Source/WebCore/css/CSSGradientValue.cpp

@@ -290 +290 @@
 
                 // Clamp the positions to 1 and set the color.
-                for (size_t i = index + 1; i <= lastStopIndex; ++i) {
+                for (size_t i = index + 1; i < numStops; ++i) {
                     stops[i].offset = 1;
                     stops[i].color = blendedColor;
@@ -720 +720 @@
             result.append(m_angle->cssText());
             wroteSomething = true;
-        } else if ((firstX() || firstY()) && !(!firstX() && firstY() && firstY()->valueID() == CSSValueBottom)) {
+        } else if (firstX() || (firstY() && firstY()->valueID() != CSSValueBottom)) {
             result.appendLiteral("to ");
             appendSpaceSeparatedOptionalCSSPtrText(result, firstX(), firstY());
@@ -946 +946 @@
         }
 
-        if (firstX() || firstY()) {
+        if ((firstX() && !firstX()->isCenterPosition()) || (firstY() && !firstY()->isCenterPosition())) {
             if (wroteSomething)
                 result.append(' ');
@@ -1226 +1226 @@
     bool wroteSomething = false;
 
-    if (m_angle) {
+    if (m_angle && m_angle->computeDegrees() > 0) {
         result.append("from ", m_angle->cssText());
         wroteSomething = true;
     }
 
-    if (firstX() && firstY()) {
+    if ((firstX() && !firstX()->isCenterPosition()) || (firstY() && !firstY()->isCenterPosition())) {
         if (wroteSomething)
             result.append(' ');