Changeset 27632 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Nov 8, 2007, 9:48:49 PM (18 years ago)

Author:

Darin Adler

Message:

Reviewed by Oliver.

• ​http://bugs.webkit.org/show_bug.cgi?id=15904 more speed-ups possible by tightening up int version of JSImmediate

1% improvement of SunSpider

• kjs/JSImmediate.h: Eliminate the now-unneeded FPBitValues struct template. (KJS::JSImmediate::from): Overload for most numeric types; many types can do fewer branches and checks. (KJS::JSImmediate::getUInt32): Removed unneeded check for undefined. (KJS::JSImmediate::getTruncatedInt32): Ditto. (KJS::JSImmediate::getTruncatedUInt32): Ditto. There's no difference any more between getUInt32 and getTruncatedUInt32, so that's worth a rename and merge later.

• kjs/grammar.y: Update since fromDouble is now just from.
• kjs/nodes.h: Ditto.

• kjs/value.h: (KJS::jsNumber): Overload for most numeric types.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -656 +656 @@
 }
 
-JSValue *ArgumentListNode::evaluate(ExecState *)
-{
-  ASSERT(0);
-  return 0; // dummy, see evaluateList()
-}
-
 // ECMA 11.2.4
 void ArgumentListNode::evaluateList(ExecState* exec, List& list)
@@ -678 +672 @@
     if (listNode)
         nodeStack.append(listNode.get());
-}
-
-JSValue *ArgumentsNode::evaluate(ExecState *)
-{
-  ASSERT(0);
-  return 0; // dummy, see evaluateList()
 }