Changeset 27678 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Nov 10, 2007, 5:07:00 PM (18 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

Reviewed by Sam.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15927 REGRESSION(r27487): delete a.c followed by defineGetter("c", ...) incorrectly deletes another property and <rdar://problem/5586384> REGRESSION (r27487): Can't switch out of Edit HTML Source mode on Leopard Wiki

Test: fast/js/delete-then-put.html

• kjs/property_map.cpp: (KJS::PropertyMap::put): Added a missing "- 1"; code to find an empty slot was not working. (KJS::PropertyMap::checkConsistency): Added a missing range check that would have caught this problem before.

• roll out a last-minute change to my evaluateToBoolean patch that was incorrect.

• kjs/nodes.h: (KJS::ExprStatementNode::ExprStatementNode): Take out call to optimizeForUnnecessaryResult, since the result is used in some cases.

LayoutTests:

Reviewed by Sam.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15927 delete a.c followed by defineGetter("c", ...) incorrectly deletes another property

• fast/js/delete-then-put-expected.txt: Added.
• fast/js/delete-then-put.html: Added.
• fast/js/resources/delete-then-put.js: Added.

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.h

@@ -1577 +1577 @@
   class ExprStatementNode : public StatementNode {
   public:
-    ExprStatementNode(ExpressionNode* e) KJS_FAST_CALL : expr(e)
-    {
-        e->optimizeForUnnecessaryResult();
-    }
+    ExprStatementNode(ExpressionNode* e) KJS_FAST_CALL : expr(e) { }
     virtual void optimizeVariableAccess(FunctionBodyNode*, DeclarationStacks::NodeStack&) KJS_FAST_CALL;
     virtual Completion execute(ExecState*) KJS_FAST_CALL;