Changeset 27695 in webkit for trunk/JavaScriptCore/kjs/internal.cpp

Timestamp:

Nov 11, 2007, 4:34:37 PM (18 years ago)

Author:

eseidel

Message:

2007-11-10 Eric Seidel <​[email protected]>

Reviewed by darin.

Add simple type inferencing to the parser, and create custom
AddNode and LessNode subclasses based on inferred types.
​http://bugs.webkit.org/show_bug.cgi?id=15884

SunSpider claims this is at least a 0.5% speedup.

• JavaScriptCore.exp:
• kjs/grammar.y:
• kjs/internal.cpp: (KJS::NumberImp::getPrimitiveNumber): (KJS::GetterSetterImp::getPrimitiveNumber):
• kjs/internal.h:
• kjs/lexer.cpp: (KJS::Lexer::lex):
• kjs/nodes.cpp: (KJS::Node::Node): (KJS::StringNode::evaluate): (KJS::StringNode::evaluateToNumber): (KJS::StringNode::evaluateToBoolean): (KJS::RegExpNode::evaluate): (KJS::UnaryPlusNode::optimizeVariableAccess): (KJS::AddNode::evaluate): (KJS::AddNode::evaluateToNumber): (KJS::AddNumbersNode::inlineEvaluateToNumber): (KJS::AddNumbersNode::evaluate): (KJS::AddNumbersNode::evaluateToNumber): (KJS::AddStringsNode::evaluate): (KJS::AddStringLeftNode::evaluate): (KJS::AddStringRightNode::evaluate): (KJS::lessThan): (KJS::lessThanEq): (KJS::LessNumbersNode::evaluate): (KJS::LessStringsNode::evaluate):
• kjs/nodes.h: (KJS::ExpressionNode::): (KJS::RegExpNode::): (KJS::RegExpNode::precedence): (KJS::TypeOfResolveNode::): (KJS::LocalVarTypeOfNode::): (KJS::UnaryPlusNode::): (KJS::UnaryPlusNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::AddNumbersNode::): (KJS::AddStringLeftNode::): (KJS::AddStringRightNode::): (KJS::AddStringsNode::): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::LessNumbersNode::): (KJS::LessStringsNode::):
• kjs/nodes2string.cpp: (KJS::StringNode::streamTo):
• kjs/object.cpp:
• kjs/object.h:
• kjs/value.h: (KJS::JSValue::getPrimitiveNumber):

File:

• trunk/JavaScriptCore/kjs/internal.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/internal.cpp

@@ -57 +57 @@
 }
 
-bool StringImp::getPrimitiveNumber(ExecState*, double& number) const
-{
+bool StringImp::getPrimitiveNumber(ExecState*, double& number, JSValue*& value)
+{
+    value = this;
     number = val.toDouble();
     return false;
@@ -90 +91 @@
 }
 
-bool NumberImp::getPrimitiveNumber(ExecState*, double& number) const
+bool NumberImp::getPrimitiveNumber(ExecState*, double& number, JSValue*& value)
 {
     number = val;
+    value = this;
     return true;
 }
@@ -159 +161 @@
 }
 
-bool GetterSetterImp::getPrimitiveNumber(ExecState*, double& number) const
-{
-    ASSERT(false);
+bool GetterSetterImp::getPrimitiveNumber(ExecState*, double& number, JSValue*& value)
+{
+    ASSERT_NOT_REACHED();
     number = 0;
+    value = 0;
     return true;
 }