Changeset 27695 in webkit for trunk/JavaScriptCore/kjs/value.h

Timestamp:

Nov 11, 2007, 4:34:37 PM (18 years ago)

Author:

eseidel

Message:

2007-11-10 Eric Seidel <​[email protected]>

Reviewed by darin.

Add simple type inferencing to the parser, and create custom
AddNode and LessNode subclasses based on inferred types.
​http://bugs.webkit.org/show_bug.cgi?id=15884

SunSpider claims this is at least a 0.5% speedup.

• JavaScriptCore.exp:
• kjs/grammar.y:
• kjs/internal.cpp: (KJS::NumberImp::getPrimitiveNumber): (KJS::GetterSetterImp::getPrimitiveNumber):
• kjs/internal.h:
• kjs/lexer.cpp: (KJS::Lexer::lex):
• kjs/nodes.cpp: (KJS::Node::Node): (KJS::StringNode::evaluate): (KJS::StringNode::evaluateToNumber): (KJS::StringNode::evaluateToBoolean): (KJS::RegExpNode::evaluate): (KJS::UnaryPlusNode::optimizeVariableAccess): (KJS::AddNode::evaluate): (KJS::AddNode::evaluateToNumber): (KJS::AddNumbersNode::inlineEvaluateToNumber): (KJS::AddNumbersNode::evaluate): (KJS::AddNumbersNode::evaluateToNumber): (KJS::AddStringsNode::evaluate): (KJS::AddStringLeftNode::evaluate): (KJS::AddStringRightNode::evaluate): (KJS::lessThan): (KJS::lessThanEq): (KJS::LessNumbersNode::evaluate): (KJS::LessStringsNode::evaluate):
• kjs/nodes.h: (KJS::ExpressionNode::): (KJS::RegExpNode::): (KJS::RegExpNode::precedence): (KJS::TypeOfResolveNode::): (KJS::LocalVarTypeOfNode::): (KJS::UnaryPlusNode::): (KJS::UnaryPlusNode::precedence): (KJS::AddNode::): (KJS::AddNode::precedence): (KJS::AddNumbersNode::): (KJS::AddStringLeftNode::): (KJS::AddStringRightNode::): (KJS::AddStringsNode::): (KJS::LessNode::): (KJS::LessNode::precedence): (KJS::LessNumbersNode::): (KJS::LessStringsNode::):
• kjs/nodes2string.cpp: (KJS::StringNode::streamTo):
• kjs/object.cpp:
• kjs/object.h:
• kjs/value.h: (KJS::JSValue::getPrimitiveNumber):

File:

• trunk/JavaScriptCore/kjs/value.h (modified) (3 diffs)

trunk/JavaScriptCore/kjs/value.h

@@ -82 +82 @@
     // Basic conversions.
     JSValue* toPrimitive(ExecState* exec, JSType preferredType = UnspecifiedType) const;
-    bool getPrimitiveNumber(ExecState* exec, double& number) const;
+    bool getPrimitiveNumber(ExecState* exec, double& number, JSValue*& value);
 
     bool toBoolean(ExecState *exec) const;
@@ -150 +150 @@
     // Basic conversions.
     virtual JSValue *toPrimitive(ExecState *exec, JSType preferredType = UnspecifiedType) const = 0;
-    virtual bool getPrimitiveNumber(ExecState* exec, double& number) const = 0;
+    virtual bool getPrimitiveNumber(ExecState* exec, double& number, JSValue*& value) = 0;
     virtual bool toBoolean(ExecState *exec) const = 0;
     virtual double toNumber(ExecState *exec) const = 0;
@@ -421 +421 @@
 }
 
-inline bool JSValue::getPrimitiveNumber(ExecState* exec, double& number) const
+inline bool JSValue::getPrimitiveNumber(ExecState* exec, double& number, JSValue*& value)
 {
     if (JSImmediate::isImmediate(this)) {
         number = JSImmediate::toDouble(this);
+        value = this;
         return true;
     }
-    return asCell()->getPrimitiveNumber(exec, number);
+    return asCell()->getPrimitiveNumber(exec, number, value);
 }