Changeset 27702 in webkit for trunk/JavaScriptCore/kjs/nodes.h

Timestamp:

Nov 11, 2007, 8:27:33 PM (18 years ago)

Author:

[email protected]

Message:

Reviewed by Sam Weinig.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15902
15% of string-validate-input.js is spent compiling the same regular expression

Store a compiled representation of the regular expression in the AST.

Only a .2% SunSpider speedup overall, but a 10.6% speedup on
string-validate-input.js.

• kjs/nodes.cpp: (KJS::RegExpNode::evaluate):
• kjs/nodes.h: (KJS::RegExpNode::):
• kjs/nodes2string.cpp: (KJS::RegExpNode::streamTo):
• kjs/regexp.cpp: (KJS::RegExp::flags):
• kjs/regexp.h: (KJS::RegExp::pattern):
• kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): (KJS::RegExpObjectImp::createRegExpImp):
• kjs/regexp_object.h:

File:

• trunk/JavaScriptCore/kjs/nodes.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/nodes.h

@@ -29 +29 @@
 #include "Parser.h"
 #include "internal.h"
+#include "RegExp.h"
 #include "SymbolTable.h"
 #include <wtf/ListRefPtr.h>
@@ -271 +272 @@
   public:
     RegExpNode(const UString& pattern, const UString& flags) KJS_FAST_CALL 
-      : m_pattern(pattern), m_flags(flags) { }
-    virtual JSValue* evaluate(ExecState*) KJS_FAST_CALL;
+        : m_regExp(new RegExp(pattern, flags))
+    {
+    }
+    JSValue* evaluate(ExecState*) KJS_FAST_CALL;
     virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
     virtual Precedence precedence() const { return PrecPrimary; }
   private:
-    UString m_pattern;
-    UString m_flags;
+    RefPtr<RegExp> m_regExp;
   };