Changeset 27702 in webkit for trunk/JavaScriptCore/kjs/regexp.h

Timestamp:

Nov 11, 2007, 8:27:33 PM (18 years ago)

Author:

[email protected]

Message:

Reviewed by Sam Weinig.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15902
15% of string-validate-input.js is spent compiling the same regular expression

Store a compiled representation of the regular expression in the AST.

Only a .2% SunSpider speedup overall, but a 10.6% speedup on
string-validate-input.js.

• kjs/nodes.cpp: (KJS::RegExpNode::evaluate):
• kjs/nodes.h: (KJS::RegExpNode::):
• kjs/nodes2string.cpp: (KJS::RegExpNode::streamTo):
• kjs/regexp.cpp: (KJS::RegExp::flags):
• kjs/regexp.h: (KJS::RegExp::pattern):
• kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): (KJS::RegExpObjectImp::createRegExpImp):
• kjs/regexp_object.h:

File:

• trunk/JavaScriptCore/kjs/regexp.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/regexp.h

@@ -47 +47 @@
     int refCount() { return m_refCount; }
 
-    bool global() const { return m_flags & Global; }
-    bool ignoreCase() const { return m_flags & IgnoreCase; }
-    bool multiline() const { return m_flags & Multiline; }
+    bool global() const { return m_flagBits & Global; }
+    bool ignoreCase() const { return m_flagBits & IgnoreCase; }
+    bool multiline() const { return m_flagBits & Multiline; }
+
     const UString& pattern() const { return m_pattern; }
+    const UString& flags() const { return m_flags; }
 
     bool isValid() const { return !m_constructionError; }
@@ -64 +66 @@
     
     // Data supplied by caller.
-    UString m_pattern;
-    int m_flags;
+    UString m_pattern; // FIXME: Just decompile m_regExp instead of storing this.
+    UString m_flags; // FIXME: Just decompile m_regExp instead of storing this.
+    int m_flagBits;
 
     // Data supplied by PCRE.