Changeset 27702 in webkit for trunk/JavaScriptCore/kjs/regexp_object.cpp

Timestamp:

Nov 11, 2007, 8:27:33 PM (18 years ago)

Author:

[email protected]

Message:

Reviewed by Sam Weinig.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15902
15% of string-validate-input.js is spent compiling the same regular expression

Store a compiled representation of the regular expression in the AST.

Only a .2% SunSpider speedup overall, but a 10.6% speedup on
string-validate-input.js.

• kjs/nodes.cpp: (KJS::RegExpNode::evaluate):
• kjs/nodes.h: (KJS::RegExpNode::):
• kjs/nodes2string.cpp: (KJS::RegExpNode::streamTo):
• kjs/regexp.cpp: (KJS::RegExp::flags):
• kjs/regexp.h: (KJS::RegExp::pattern):
• kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): (KJS::RegExpObjectImp::createRegExpImp):
• kjs/regexp_object.h:

File:

• trunk/JavaScriptCore/kjs/regexp_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/regexp_object.cpp

@@ -449 +449 @@
   UString pattern = arg0->isUndefined() ? UString("") : arg0->toString(exec);
   UString flags = arg1->isUndefined() ? UString("") : arg1->toString(exec);
-  RefPtr<RegExp> regExp = new RegExp(pattern, flags);
-
-  return regExp->isValid()
-    ? new RegExpImp(static_cast<RegExpPrototype*>(exec->lexicalInterpreter()->builtinRegExpPrototype()), regExp.release())
-    : throwError(exec, SyntaxError, UString("Invalid regular expression: ").append(regExp->errorMessage()));
+  
+  return createRegExpImp(exec, new RegExp(pattern, flags));
+}
+
+JSObject* RegExpObjectImp::createRegExpImp(ExecState* exec, PassRefPtr<RegExp> regExp)
+{
+    return regExp->isValid()
+        ? new RegExpImp(static_cast<RegExpPrototype*>(exec->lexicalInterpreter()->builtinRegExpPrototype()), regExp)
+        : throwError(exec, SyntaxError, UString("Invalid regular expression: ").append(regExp->errorMessage()));
 }