Changeset 277370 in webkit for trunk/Source/JavaScriptCore/jit/JIT.cpp

Timestamp:

May 12, 2021, 8:48:26 AM (4 years ago)

Author:

[email protected]

Message:

Remove dead code around ENABLE(OPCODE_SAMPLING) and ENABLE(CODEBLOCK_SAMPLING).
​https://bugs.webkit.org/show_bug.cgi?id=225699

Reviewed by Tadeu Zagallo.

This code revolves around an Interpreter::sampler() method which returns a
SamplingTool*. Neither the Interpreter method nor the SamplingTool class exists
anymore.

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):

• jit/JIT.h:
• jit/JITCall.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

• jit/JITInlines.h:

(JSC::JIT::sampleInstruction): Deleted.
(JSC::JIT::sampleCodeBlock): Deleted.

• jit/JITOperations.cpp:
• jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

• runtime/ScriptExecutable.h:

(JSC::ScriptExecutable::finishCreation): Deleted.

File:

• trunk/Source/JavaScriptCore/jit/JIT.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jit/JIT.cpp

@@ -252 +252 @@
 
         m_pcToCodeOriginMapBuilder.appendItem(label(), CodeOrigin(m_bytecodeIndex));
-
-#if ENABLE(OPCODE_SAMPLING)
-        if (m_bytecodeIndex > 0) // Avoid the overhead of sampling op_enter twice.
-            sampleInstruction(currentInstruction);
-#endif
 
         m_labels[m_bytecodeIndex.offset()] = label();
@@ -748 +743 @@
     Label beginLabel(this);
 
-    sampleCodeBlock(m_codeBlock);
-#if ENABLE(OPCODE_SAMPLING)
-    sampleInstruction(m_codeBlock->instructions().begin());
-#endif
-
     int frameTopOffset = stackPointerOffsetFor(m_codeBlock) * sizeof(Register);
     unsigned maxFrameSize = -frameTopOffset;