Changeset 27749 in webkit for trunk/JavaScriptCore/kjs/nodes.h


Ignore:
Timestamp:
Nov 13, 2007, 12:34:25 AM (18 years ago)
Author:
[email protected]
Message:

2007-11-13 Eric Seidel <​[email protected]>

Reviewed by Maciej.

Clean up evaluateToBoolean functions to use inlines instead of copy/paste code

  • kjs/JSImmediate.h:
  • kjs/nodes.cpp: (KJS::GreaterNode::inlineEvaluateToBoolean): (KJS::GreaterNode::evaluate): (KJS::LessEqNode::inlineEvaluateToBoolean): (KJS::LessEqNode::evaluate): (KJS::GreaterEqNode::inlineEvaluateToBoolean): (KJS::GreaterEqNode::evaluate): (KJS::InNode::evaluateToBoolean): (KJS::EqualNode::inlineEvaluateToBoolean): (KJS::EqualNode::evaluate): (KJS::NotEqualNode::inlineEvaluateToBoolean): (KJS::NotEqualNode::evaluate): (KJS::StrictEqualNode::inlineEvaluateToBoolean): (KJS::StrictEqualNode::evaluate): (KJS::NotStrictEqualNode::inlineEvaluateToBoolean): (KJS::NotStrictEqualNode::evaluate):
  • kjs/nodes.h:
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/kjs/nodes.h

    r27747 r27749  
    12881288    virtual Precedence precedence() const { return PrecRelational; }
    12891289  private:
     1290    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    12901291    RefPtr<ExpressionNode> expr1;
    12911292    RefPtr<ExpressionNode> expr2;
    … …  
    13021303    virtual Precedence precedence() const { return PrecRelational; }
    13031304  private:
     1305    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    13041306    RefPtr<ExpressionNode> expr1;
    13051307    RefPtr<ExpressionNode> expr2;
    … …  
    13161318    virtual Precedence precedence() const { return PrecRelational; }
    13171319  private:
     1320    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    13181321    RefPtr<ExpressionNode> expr1;
    13191322    RefPtr<ExpressionNode> expr2;
    … …  
    13581361    virtual Precedence precedence() const { return PrecEquality; }
    13591362  private:
     1363    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    13601364    RefPtr<ExpressionNode> expr1;
    13611365    RefPtr<ExpressionNode> expr2;
    … …  
    13721376    virtual Precedence precedence() const { return PrecEquality; }
    13731377  private:
     1378    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    13741379    RefPtr<ExpressionNode> expr1;
    13751380    RefPtr<ExpressionNode> expr2;
    … …  
    13861391    virtual Precedence precedence() const { return PrecEquality; }
    13871392  private:
     1393    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    13881394    RefPtr<ExpressionNode> expr1;
    13891395    RefPtr<ExpressionNode> expr2;
    … …  
    14001406    virtual Precedence precedence() const { return PrecEquality; }
    14011407  private:
     1408    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    14021409    RefPtr<ExpressionNode> expr1;
    14031410    RefPtr<ExpressionNode> expr2;
    … …  
    14711478    virtual Precedence precedence() const { return PrecLogicalAnd; }
    14721479  private:
    1473         ALWAYS_INLINE int32_t inlineEvaluateToInt32(ExecState*);
     1480    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    14741481    RefPtr<ExpressionNode> expr1;
    14751482    RefPtr<ExpressionNode> expr2;
    … …  
    14861493    virtual Precedence precedence() const { return PrecLogicalOr; }
    14871494  private:
    1488         ALWAYS_INLINE int32_t inlineEvaluateToInt32(ExecState*);
     1495    ALWAYS_INLINE bool inlineEvaluateToBoolean(ExecState*);
    14891496    RefPtr<ExpressionNode> expr1;
    14901497    RefPtr<ExpressionNode> expr2;
Note: See TracChangeset for help on using the changeset viewer.