Changeset 2777 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Nov 20, 2002, 12:53:04 AM (23 years ago)

Author:

darin

Message:

• add a couple of list operations to avoid clearing lists so much during sorting; gives 1.5% iBench

• kjs/types.h: Added replaceFirst/replaceLast.
• kjs/types.cpp: (List::replaceFirst), (List::replaceLast): Added.

• kjs/array_object.cpp: (compareWithCompareFunctionForQSort): Use replaceFirst/replaceLast.

• kjs/property_map.cpp: Put in an ifdef so I can re-add/remove the single entry to see if it has outlived its usefulness. (It hasn't yet.)

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -215 +215 @@
         , compareFunction(cf)
         , globalObject(e->interpreter()->globalObject())
-    { }
+    {
+        arguments.append(Undefined());
+        arguments.append(Undefined());
+    }
 
     ExecState *exec;
@@ -229 +232 @@
     CompareWithCompareFunctionArguments *args = compareWithCompareFunctionArguments;
     
-    args->arguments.clear();
-    args->arguments.append(*(ValueImp **)a);
-    args->arguments.append(*(ValueImp **)b);
+    args->arguments.replaceFirst(*(ValueImp **)a);
+    args->arguments.replaceLast(*(ValueImp **)b);
     return args->compareFunction->call(args->exec, args->globalObject, args->arguments)
         .toInt32(args->exec);