Changeset 277917 in webkit for trunk/Tools/TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp

Timestamp:

May 22, 2021, 4:17:01 AM (4 years ago)

Author:

[email protected]

Message:

Unreviewed, reverting r277913.
​https://bugs.webkit.org/show_bug.cgi?id=226140

Caused multiple layout-test crash on mac debug queues

Reverted changeset:

"Replace LockHolder with Locker in local variables"
​https://bugs.webkit.org/show_bug.cgi?id=226133
​https://trac.webkit.org/changeset/277913

File:

• trunk/Tools/TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp (modified) (2 diffs)

trunk/Tools/TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp

@@ -52 +52 @@
     GRefPtr<GFile> file = adoptGRef(g_file_new_for_path(currentDirectory.get()));
 
-    Locker locker { context.m_lock };
+    LockHolder locker(context.m_lock);
     queue->dispatch([&](void) {
         EXPECT_TRUE(g_main_context_get_thread_default());
@@ -60 +60 @@
             [](GObject*, GAsyncResult*, gpointer userData) {
                 TestingContext* context = static_cast<TestingContext*>(userData);
-                Locker locker { context->m_lock };
+                LockHolder locker(context->m_lock);
                 EXPECT_EQ(g_main_context_get_thread_default(), context->m_mainContext);
                 context->m_testCompleted.notifyOne();