Changeset 278069 in webkit for trunk/Source/JavaScriptCore/dfg/DFGCommon.cpp

Timestamp:

May 25, 2021, 5:37:19 PM (4 years ago)

Author:

Chris Dumez

Message:

Use UncheckedLock less in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=226212

Reviewed by Saam Barati.

Source/JavaScriptCore:

Use UncheckedLock less in JavaScriptCore as it is being phased out in favor of Lock, which
enables Clang thread safety analysis.

• assembler/testmasm.cpp:
• dfg/DFGCommon.cpp:
• dynbench.cpp:
• heap/Heap.cpp:
• heap/Heap.h:
• inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
• runtime/JSLock.cpp:
• runtime/JSLock.h:
• runtime/VM.h:

Source/WTF:

Add support for unlockEarly() to Locker<Lock> specialization, for consistency
with the generic Locker.

• wtf/Lock.h:

File:

• trunk/Source/JavaScriptCore/dfg/DFGCommon.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGCommon.cpp

@@ -36 +36 @@
 const char* const tierName = "DFG ";
 
-static UncheckedLock crashLock;
+static Lock crashLock;
 
-void startCrashing()
+// Use WTF_IGNORES_THREAD_SAFETY_ANALYSIS since the function keeps holding the lock when returning.
+void startCrashing() WTF_IGNORES_THREAD_SAFETY_ANALYSIS
 {
     crashLock.lock();