Changeset 278069 in webkit for trunk/Source/JavaScriptCore/dynbench.cpp

Timestamp:

May 25, 2021, 5:37:19 PM (4 years ago)

Author:

Chris Dumez

Message:

Use UncheckedLock less in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=226212

Reviewed by Saam Barati.

Source/JavaScriptCore:

Use UncheckedLock less in JavaScriptCore as it is being phased out in favor of Lock, which
enables Clang thread safety analysis.

• assembler/testmasm.cpp:
• dfg/DFGCommon.cpp:
• dynbench.cpp:
• heap/Heap.cpp:
• heap/Heap.h:
• inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
• runtime/JSLock.cpp:
• runtime/JSLock.h:
• runtime/VM.h:

Source/WTF:

Add support for unlockEarly() to Locker<Lock> specialization, for consistency
with the generic Locker.

• wtf/Lock.h:

File:

• trunk/Source/JavaScriptCore/dynbench.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/dynbench.cpp

@@ -41 +41 @@
 namespace {
 
-UncheckedLock crashLock;
+Lock crashLock;
 const char* nameFilter;
 unsigned requestedIterationCount;
@@ -70 +70 @@
 } // anonymous namespace
 
-int main(int argc, char** argv)
+// Use WTF_IGNORES_THREAD_SAFETY_ANALYSIS because the function keeps holding crashLock when returning.
+int main(int argc, char** argv) WTF_IGNORES_THREAD_SAFETY_ANALYSIS
 {
     if (argc >= 2) {