Changeset 2783 in webkit for trunk/JavaScriptCore/kjs/date_object.cpp

Timestamp:

Nov 20, 2002, 1:12:14 PM (23 years ago)

Author:

darin

Message:

• decrease ref/deref -- 5% speedup in iBench

• JavaScriptCore.pbproj/project.pbxproj: Added array_instance.h
• kjs/array_instance.h: Added so it can be shared by function.h.

• kjs/array_object.cpp:
• kjs/array_object.h:
• kjs/bool_object.cpp:
• kjs/bool_object.h:
• kjs/collector.cpp:
• kjs/date_object.cpp:
• kjs/date_object.h:
• kjs/error_object.cpp:
• kjs/function.cpp:
• kjs/function.h:
• kjs/function_object.cpp:
• kjs/internal.cpp:
• kjs/internal.h:
• kjs/math_object.cpp:
• kjs/nodes.cpp:
• kjs/number_object.cpp:
• kjs/object.cpp:
• kjs/object.h:
• kjs/object_object.cpp:
• kjs/property_map.cpp:
• kjs/reference.cpp:
• kjs/reference.h:
• kjs/regexp_object.cpp:
• kjs/string_object.cpp:
• kjs/string_object.h:
• kjs/value.cpp:
• kjs/value.h: Switched lots of interfaces so they don't require ref/deref.

File:

• trunk/JavaScriptCore/kjs/date_object.cpp (modified) (6 diffs)

trunk/JavaScriptCore/kjs/date_object.cpp

@@ -210 +210 @@
 const ClassInfo DateInstanceImp::info = {"Date", 0, 0, 0};
 
-DateInstanceImp::DateInstanceImp(const Object &proto)
+DateInstanceImp::DateInstanceImp(ObjectImp *proto)
   : ObjectImp(proto)
 {
@@ -272 +272 @@
 DatePrototypeImp::DatePrototypeImp(ExecState *,
                                    ObjectPrototypeImp *objectProto)
-  : DateInstanceImp(Object(objectProto))
+  : DateInstanceImp(objectProto)
 {
   Value protect(this);
-  setInternalValue(Number(NaN));
+  setInternalValue(NumberImp::create(NaN));
   // The constructor will be added later, after DateObjectImp has been built
 }
@@ -293 +293 @@
 {
   Value protect(this);
-  put(exec,lengthPropertyName,Number(len),DontDelete|ReadOnly|DontEnum);
+  putDirect(lengthPropertyName, len, DontDelete|ReadOnly|DontEnum);
 }
 
@@ -524 +524 @@
 {
   Value protect(this);
+  
   // ECMA 15.9.4.1 Date.prototype
-  put(exec,prototypePropertyName, Object(dateProto), DontEnum|DontDelete|ReadOnly);
-
-  put(exec,"parse", Object(new DateObjectFuncImp(exec,funcProto,DateObjectFuncImp::Parse, 1)), DontEnum);
-  put(exec,"UTC",   Object(new DateObjectFuncImp(exec,funcProto,DateObjectFuncImp::UTC,   7)),   DontEnum);
+  putDirect(prototypePropertyName, dateProto, DontEnum|DontDelete|ReadOnly);
+
+  static const Identifier parsePropertyName("parse");
+  putDirect(parsePropertyName, new DateObjectFuncImp(exec,funcProto,DateObjectFuncImp::Parse, 1), DontEnum);
+  static const Identifier UTCPropertyName("UTC");
+  putDirect("UTC",   new DateObjectFuncImp(exec,funcProto,DateObjectFuncImp::UTC,   7),   DontEnum);
 
   // no. of arguments for constructor
-  put(exec,lengthPropertyName, Number(7), ReadOnly|DontDelete|DontEnum);
+  putDirect(lengthPropertyName, 7, ReadOnly|DontDelete|DontEnum);
 }
 
@@ -602 +605 @@
 
   Object proto = exec->interpreter()->builtinDatePrototype();
-  Object ret(new DateInstanceImp(proto));
+  Object ret(new DateInstanceImp(proto.imp()));
   ret.setInternalValue(timeClip(value));
   return ret;
@@ -637 +640 @@
 {
   Value protect(this);
-  put(exec,lengthPropertyName,Number(len),DontDelete|ReadOnly|DontEnum);
+  putDirect(lengthPropertyName, len, DontDelete|ReadOnly|DontEnum);
 }