Changeset 2783 in webkit for trunk/JavaScriptCore/kjs/function.cpp

Timestamp:

Nov 20, 2002, 1:12:14 PM (23 years ago)

Author:

darin

Message:

• decrease ref/deref -- 5% speedup in iBench

• JavaScriptCore.pbproj/project.pbxproj: Added array_instance.h
• kjs/array_instance.h: Added so it can be shared by function.h.

• kjs/array_object.cpp:
• kjs/array_object.h:
• kjs/bool_object.cpp:
• kjs/bool_object.h:
• kjs/collector.cpp:
• kjs/date_object.cpp:
• kjs/date_object.h:
• kjs/error_object.cpp:
• kjs/function.cpp:
• kjs/function.h:
• kjs/function_object.cpp:
• kjs/internal.cpp:
• kjs/internal.h:
• kjs/math_object.cpp:
• kjs/nodes.cpp:
• kjs/number_object.cpp:
• kjs/object.cpp:
• kjs/object.h:
• kjs/object_object.cpp:
• kjs/property_map.cpp:
• kjs/reference.cpp:
• kjs/reference.h:
• kjs/regexp_object.cpp:
• kjs/string_object.cpp:
• kjs/string_object.h:
• kjs/value.cpp:
• kjs/value.h: Switched lots of interfaces so they don't require ref/deref.

File:

• trunk/JavaScriptCore/kjs/function.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/function.cpp

@@ -319 +319 @@
 // ECMA 10.1.8
 ArgumentsImp::ArgumentsImp(ExecState *exec, FunctionImp *func, const List &args)
-  : ObjectImp(exec->interpreter()->builtinObjectPrototype())
+  : ArrayInstanceImp(exec->interpreter()->builtinObjectPrototype().imp(), args)
 {
   Value protect(this);
-  put(exec,calleePropertyName, Object(func), DontEnum);
-  put(exec,lengthPropertyName, Number(args.size()), DontEnum);
-  if (!args.isEmpty()) {
-    ListIterator arg = args.begin();
-    for (int i = 0; arg != args.end(); arg++, i++) {
-      put(exec,i, *arg, DontEnum);
-    }
-  }
+  putDirect(calleePropertyName, func, DontEnum);
 }
 
@@ -338 +331 @@
 // ECMA 10.1.6
 ActivationImp::ActivationImp(ExecState *exec, FunctionImp *f, const List &args)
-  : _function(f)
+  : _function(f), _arguments(args)
 {
   Value protect(this);
-  arguments = new ArgumentsImp(exec,f, args);
-  arguments->setGcAllowed();
-  put(exec, argumentsPropertyName, Object(arguments), Internal|DontDelete);
+  _argumentsObject = new ArgumentsImp(exec, f, args);
+  putDirect(argumentsPropertyName, _argumentsObject, Internal|DontDelete);
 }
 
@@ -353 +345 @@
 {
   Value protect(this);
-  put(exec,lengthPropertyName,Number(len),DontDelete|ReadOnly|DontEnum);
+  putDirect(lengthPropertyName, len, DontDelete|ReadOnly|DontEnum);
 }