Changeset 2792 in webkit for trunk/JavaScriptCore/kjs/internal.h

Timestamp:

Nov 20, 2002, 4:55:08 PM (23 years ago)

Author:

darin

Message:

• created argument list objects only on demand for a 7.5% speedup

• kjs/function.h: Change ActivationImp around.
• kjs/function.cpp: (FunctionImp::call): Pass a pointer to the arguments list to avoid ref/unref. (FunctionImp::get): Get the function pointer from the context directly, not the activation object. (ArgumentsImp::ArgumentsImp): Add an overload that takes no arguments. (ActivationImp::ActivationImp): Store a context pointer and an arguments object pointer. (ActivationImp::get): Special case for arguments, create it and return it. (ActivationImp::put): Special case for arguments, can't be set. (ActivationImp::hasProperty): Special case for arguments, return true. (ActivationImp::deleteProperty): Special case for arguments, refuse to delete. (ActivationImp::mark): Mark the arguments object. (ActivationImp::createArgumentsObject): Do the work of actually creating it. (GlobalFuncImp::call): Use stack-based objects for the ContextImp and ExecState.

• kjs/internal.h: Keep function and arguments pointer in the context.
• kjs/internal.cpp: (ContextImp::ContextImp): Don't pass in the func and args when making an ActivationImp. (InterpreterImp::evaluate): Use stack-based objects here.

• kjs/types.h: Add ArgumentList as a synonym for List, soon to be separate.

File:

• trunk/JavaScriptCore/kjs/internal.h (modified) (3 diffs)

trunk/JavaScriptCore/kjs/internal.h

@@ -200 +200 @@
   public:
     ContextImp(Object &glob, ExecState *exec, Object &thisV, CodeType type = GlobalCode,
-               ContextImp *_callingContext = 0L, FunctionImp *func = 0L, const List &args = List());
-    virtual ~ContextImp();
+               ContextImp *_callingContext = 0L, FunctionImp *func = 0L, const ArgumentList *args = 0);
+    ~ContextImp();
 
     const List scopeChain() const { return scope; }
@@ -209 +209 @@
     ContextImp *callingContext() { return callingCon; }
     ObjectImp *activationObject() { return activation.imp(); }
+    FunctionImp *function() const { return _function; }
+    const ArgumentList *arguments() const { return _arguments; }
 
     void pushScope(const Object &s);
@@ -221 +223 @@
     ContextImp *callingCon;
     Object activation;
-
+    FunctionImp *_function;
+    const ArgumentList *_arguments;
 
     LabelStack ls;