Changeset 281326 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssembler.h

Timestamp:

Aug 20, 2021, 11:09:48 AM (4 years ago)

Author:

[email protected]

Message:

[JSC] Remove unnecessary moves in Yarr's sub32 / add32 related code
​https://bugs.webkit.org/show_bug.cgi?id=228813

Reviewed by Mark Lam.

This patch adds three operand sub32 to X64 masm so that we can use it in all masms.
We use add32 and sub32 in YarrJIT to remove unnecessary mov instructions in ARM64.

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::sub32):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::sub32):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::sub32):

• assembler/testmasm.cpp:

(JSC::testSub32ArgImm):

• yarr/YarrJIT.cpp:

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssembler.h (modified) (1 diff)

trunk/Source/JavaScriptCore/assembler/MacroAssembler.h

@@ -1757 +1757 @@
         } else
             sub32(imm.asTrustedImm32(), dest);
+    }
+
+    void sub32(RegisterID src, Imm32 imm, RegisterID dest)
+    {
+        if (shouldBlind(imm)) {
+            BlindedImm32 key = additionBlindedConstant(imm);
+            sub32(src, key.value1, dest);
+            sub32(key.value2, dest);
+        } else
+            sub32(src, imm.asTrustedImm32(), dest);
     }