Changeset 282266 in webkit for trunk/Source/WebCore/rendering/RenderTableRow.cpp

Timestamp:

Sep 10, 2021, 6:41:43 AM (4 years ago)

Author:

Alan Bujtas

Message:

changing border size on rows with border-collapse not redrawing
​https://bugs.webkit.org/show_bug.cgi?id=116868
<rdar://problem/82844412>

Reviewed by Simon Fraser.

Source/WebCore:

Cells in adjacent rows share the same collapsed border.
When this collapsed border width changes on a row, the cells at the adjacent rows need to know about it too so that
they can update their size accordingly.

Test: fast/table/collapsed-border-width-change-on-row.html

• rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):

LayoutTests:

• fast/table/collapsed-border-width-change-on-row-expected.html: Added.
• fast/table/collapsed-border-width-change-on-row.html: Added.

File:

• trunk/Source/WebCore/rendering/RenderTableRow.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderTableRow.cpp

@@ -94 +94 @@
             // This only happens when borders are collapsed, since they end up affecting the border sides of the cell
             // itself.
-            for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell())
-                cell->setChildNeedsLayout(MarkOnlyThis);
+            auto propagageNeedsLayoutOnBorderSizeChange = [&] (auto& row) {
+                for (auto* cell = row.firstCell(); cell; cell = cell->nextCell())
+                    cell->setNeedsLayoutAndPrefWidthsRecalc();
+            };
+            propagageNeedsLayoutOnBorderSizeChange(*this);
+            if (auto* previousRow = this->previousRow())
+                propagageNeedsLayoutOnBorderSizeChange(*previousRow);
+            if (auto* nextRow = this->nextRow())
+                propagageNeedsLayoutOnBorderSizeChange(*nextRow);
         }
     }