Changeset 282723 in webkit for trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

Timestamp:

Sep 18, 2021, 1:56:27 AM (4 years ago)

Author:

[email protected]

Message:

[iOS Family] Delete letterpress support
​https://bugs.webkit.org/show_bug.cgi?id=230441

Reviewed by Tim Horton.

Source/WebCore:

It isn't necessary anymore.

Tests deleted.

• PlatformMac.cmake:
• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationFlagsToCSSValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator OptionSet<TextDecoration> const):

• css/CSSValueKeywords.in:
• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTextDecorationLine):

• platform/graphics/FontCascade.h:
• platform/graphics/GraphicsContext.h:
• platform/graphics/cocoa/FontCascadeCocoa.cpp: Added.

(WebCore::FontCascade::canReturnFallbackFontsForComplexText):
(WebCore::FontCascade::canExpandAroundIdeographsInComplexText):

• platform/graphics/cocoa/FontCascadeCocoa.mm: Removed.
• platform/graphics/coretext/FontCascadeCoreText.cpp:

(WebCore::FontCascade::drawGlyphs):
(WebCore::shouldUseLetterpressEffect): Deleted.

• rendering/TextPaintStyle.cpp:

(WebCore::TextPaintStyle::operator== const):
(WebCore::computeTextPaintStyle):
(WebCore::updateGraphicsContext):

• rendering/TextPaintStyle.h:
• rendering/style/RenderStyleConstants.cpp:

(WebCore::operator<<):

• rendering/style/RenderStyleConstants.h:

Source/WTF:

• wtf/PlatformEnable.h:
• wtf/PlatformEnableCocoa.h:

LayoutTests:

• TestExpectations:
• fast/text/letterpress-different-expected-mismatch.html: Removed.
• fast/text/letterpress-different.html: Removed.
• fast/text/letterpress-paint-expected-mismatch.html: Removed.
• fast/text/letterpress-paint.html: Removed.
• platform/ios/TestExpectations:
• platform/ios/ios/getComputedStyle-text-decoration-letterpress-expected.txt: Removed.
• platform/ios/ios/getComputedStyle-text-decoration-letterpress.html: Removed.
• platform/ios/ios/resources/getComputedStyle-text-decoration-letterpress.js: Removed.

File:

• trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -1591 +1591 @@
     if (textDecoration & TextDecoration::LineThrough)
         list->append(cssValuePool.createIdentifierValue(CSSValueLineThrough));
-#if ENABLE(LETTERPRESS)
-    if (textDecoration & TextDecoration::Letterpress)
-        list->append(cssValuePool.createIdentifierValue(CSSValueWebkitLetterpress));
-#endif
 
     if (!list->length())