Changeset 28311 in webkit for trunk/JavaScriptCore/API/JSBase.h

Timestamp:

Dec 1, 2007, 9:24:25 PM (17 years ago)

Author:

[email protected]

Message:

2007-12-01 Alp Toker <​[email protected]>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT

Add JS_EXPORT to kJSClassDefinitionEmpty.

Make the gcc compiler check take precedence over the WIN32

_WIN32

check to ensure that symbols are exported on Windows when using gcc.

Add a TODO referencing the bug about JS_EXPORT in the Win build
(​http://bugs.webkit.org/show_bug.cgi?id=16227)

Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:

extern extern const JSClassDefinition kJSClassDefinitionEmpty;

(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)

• API/JSBase.h:
• API/JSObjectRef.h:

File:

• trunk/JavaScriptCore/API/JSBase.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSBase.h

@@ -62 +62 @@
 
 #undef JS_EXPORT
-#if defined(WIN32) || defined(_WIN32)
+#if defined(__GNUC__)
+    #define JS_EXPORT __attribute__((visibility("default")))
+#elif defined(WIN32) || defined(_WIN32)
+    // TODO: Export symbols with JS_EXPORT when using MSVC.
+    // See http://bugs.webkit.org/show_bug.cgi?id=16227
     #define JS_EXPORT
-#elif defined(__GNUC__)
-    #define JS_EXPORT __attribute__((visibility("default")))
 #else
-    #define JS_EXPORT extern
+    #define JS_EXPORT
 #endif