Changeset 28311 in webkit for trunk/JavaScriptCore/API/JSObjectRef.h

Timestamp:

Dec 1, 2007, 9:24:25 PM (17 years ago)

Author:

[email protected]

Message:

2007-12-01 Alp Toker <​[email protected]>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT

Add JS_EXPORT to kJSClassDefinitionEmpty.

Make the gcc compiler check take precedence over the WIN32

_WIN32

check to ensure that symbols are exported on Windows when using gcc.

Add a TODO referencing the bug about JS_EXPORT in the Win build
(​http://bugs.webkit.org/show_bug.cgi?id=16227)

Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:

extern extern const JSClassDefinition kJSClassDefinitionEmpty;

(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)

• API/JSBase.h:
• API/JSObjectRef.h:

File:

• trunk/JavaScriptCore/API/JSObjectRef.h (modified) (1 diff)

trunk/JavaScriptCore/API/JSObjectRef.h

@@ -369 +369 @@
 definition.finalize = Finalize;
 */
-extern const JSClassDefinition kJSClassDefinitionEmpty;
+JS_EXPORT extern const JSClassDefinition kJSClassDefinitionEmpty;
 
 /*!