Changeset 283344 in webkit for trunk/Source/JavaScriptCore/jit/JIT.cpp

Timestamp:

Sep 30, 2021, 4:06:22 PM (4 years ago)

Author:

[email protected]

Message:

Regressions (r283288): [ macOS Debug ] webgl/2.0.0/conformance/state/gl-object-get-calls.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=231024
<rdar://problem/83723856>

Reviewed by Mark Lam.

Speed up our debug assert by not using a probe.

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

File:

• trunk/Source/JavaScriptCore/jit/JIT.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/jit/JIT.cpp

@@ -273 +273 @@
 #if ASSERT_ENABLED
         if (opcodeID != op_catch) {
-            probeDebug([=] (Probe::Context& ctx) {
-                CodeBlock* codeBlock = ctx.fp<CallFrame*>()->codeBlock();
-                auto* constantPool = ctx.gpr<void*>(s_constantsGPR);
-                RELEASE_ASSERT(codeBlock->baselineJITConstantPool() == constantPool);
-                auto* metadata = ctx.gpr<void*>(s_metadataGPR);
-                RELEASE_ASSERT(codeBlock->metadataTable() == metadata);
-            });
+            loadPtr(addressFor(CallFrameSlot::codeBlock), regT0);
+            loadPtr(Address(regT0, CodeBlock::offsetOfMetadataTable()), regT1);
+            loadPtr(Address(regT0, CodeBlock::offsetOfJITData()), regT0);
+            loadPtr(Address(regT0, CodeBlock::JITData::offsetOfJITConstantPool()), regT2);
+
+            auto metadataOK = branchPtr(Equal, regT1, s_metadataGPR);
+            breakpoint();
+            metadataOK.link(this);
+
+            auto constantsOK = branchPtr(Equal, regT2, s_constantsGPR);
+            breakpoint();
+            constantsOK.link(this);
         }
 #endif