Changeset 283536 in webkit for trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

Timestamp:

Oct 4, 2021, 8:52:13 PM (4 years ago)

Author:

[email protected]

Message:

Remove the "none" value from font-palette
​https://bugs.webkit.org/show_bug.cgi?id=231050
<rdar://problem/83745650>

Reviewed by Wenson Hsieh.

LayoutTests/imported/w3c:

This is being upstreamed at ​https://github.com/web-platform-tests/wpt/pull/31077.

• web-platform-tests/css/css-fonts/parsing/font-palette-invalid.html:
• web-platform-tests/css/css-fonts/parsing/font-palette-valid.html:

Source/WebCore:

The spec changed in
​https://github.com/w3c/csswg-drafts/commit/b7103b0269cde51914af02f5ca1e5582d44e7b70.
Luckily, we never implemented this anyway, so this is just a parsing change.

Tests: imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-invalid.html

imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-valid.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontPaletteFromStyle):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontPalette):

• platform/graphics/FontPalette.h:

(WebCore::operator<<):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::addAttributesForFontPalettes):

• style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertFontPalette):

File:

• trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -1842 +1842 @@
     auto fontPalette = style.fontDescription().fontPalette();
     switch (fontPalette.type) {
-    case FontPalette::Type::None:
-        return CSSValuePool::singleton().createIdentifierValue(CSSValueNone);
     case FontPalette::Type::Normal:
         return CSSValuePool::singleton().createIdentifierValue(CSSValueNormal);