Unprefix -webkit-appearance
https://bugs.webkit.org/show_bug.cgi?id=231534
rdar://84112934
Reviewed by Wenson Hsieh.
LayoutTests/imported/w3c:
Mark progressions.
The remaining test failures deal with <compat-auto> keywords and will
be addressed on a case-by-case basis.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- web-platform-tests/css/css-ui/appearance-initial-value-001-expected.txt:
- web-platform-tests/css/css-ui/appearance-parsing-expected.txt:
- web-platform-tests/css/css-ui/appearance-property-expected.txt:
- web-platform-tests/css/css-ui/appearance-serialization-expected.txt:
- web-platform-tests/css/css-ui/inheritance-expected.txt:
- web-platform-tests/css/css-ui/webkit-appearance-parsing-expected.txt:
- web-platform-tests/css/css-ui/webkit-appearance-property-expected.txt:
- web-platform-tests/css/css-ui/webkit-appearance-serialization-expected.txt:
- web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:
Source/WebCore:
Make '-webkit-appearance' a parse time alias of 'appearance', as
specified in https://www.w3.org/TR/css-ui-4/#appearance-switching.
The remaining test failures deal with <compat-auto> keywords and
non-standard values. For example, we cannot remove '-apple-pay-button'
as a valid value, since sites use it to render an Apple Pay button.
Remaining failures will be addressed on a case-by-case basis to avoid
compatibility issues. Note that this is an open spec issue (Issue 7 on
the spec linked above).
Most importantly, this change allows authors to use 'appearance: none'
and 'appearance: auto' to control the appearance of widgets.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
LayoutTests:
Mark two tests ref tests as failing. These tests were incorrectly passing
due to lack of support for 'appearance'. The tests use <compat-auto> values
which we do not yet support due to compat risk with internal apps. These
tests will be addressed on a case-by-case basis.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- platform/glib/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/glib/svg/css/getComputedStyle-basic-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:
- platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- platform/ios/svg/css/getComputedStyle-basic-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
