Changeset 2843 in webkit for trunk/JavaScriptCore/kjs/collector.cpp

Timestamp:

Nov 22, 2002, 11:49:05 PM (23 years ago)

Author:

darin

Message:

JavaScriptCore:

• replaced List class with a vector rather than a linked list, changed it to use a pool of instances instead of all the nodes allocated off of the heap; gives 10% gain on iBench

• kjs/list.h: Complete rewrite.
• kjs/list.cpp: Ditto.

• kjs/array_object.cpp: (compareWithCompareFunctionForQSort): Go back to doing a clear and two appends here. Fast with the new list implementation.

• kjs/collector.h: Remove _COLLECTOR hack and just make rootObjectClasses return a const void *.
• kjs/collector.cpp: Remove _COLLECTOR hack, and various other minor tweaks.

WebCore:

• khtml/ecma/kjs_window.cpp: Remove _COLLECTOR hack.

• kwq/WebCoreJavaScript.h:
• kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): Update for name change -- root object classes, not all live object classes.

• force-js-clean-timestamp: Make sure we don't have more build problems.

WebKit:

• Misc.subproj/WebCoreStatistics.h:
• Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptRootObjectClasses]): Update for name change -- root object classes, not all live object classes.

WebBrowser:

• Debug/CacheController.m: (-[CacheController refreshJavaScriptStatisticsMatrix]): Update for name change -- root object classes, not all live object classes.

File:

• trunk/JavaScriptCore/kjs/collector.cpp (modified) (4 diffs)

trunk/JavaScriptCore/kjs/collector.cpp

@@ -2 +2 @@
 /*
  *  This file is part of the KDE libraries
- *  Copyright (C) 1999-2000 Harri Porten ([email protected])
- *  Copyright (C) 2001 Peter Kelly ([email protected])
+ *  Copyright (C) 2002 Apple Computer, Inc.
  *
  *  This library is free software; you can redistribute it and/or
@@ -21 +20 @@
  */
 
+#include "collector.h"
+
+#include "value.h"
+#include "internal.h"
+
 #if APPLE_CHANGES
-#define _COLLECTOR
 #include <CoreFoundation/CoreFoundation.h>
 #include <cxxabi.h>
 #endif
 
-#include <collector.h>
-#include <value.h>
-#include <internal.h>
-
-using namespace KJS;
+namespace KJS {
 
 // tunable parameters
@@ -360 +359 @@
 }
 
-// FIXME: Rename. Root object classes are more useful than live object classes.
-CFSetRef Collector::liveObjectClasses()
+const void *Collector::rootObjectClasses()
 {
   CFMutableSetRef classes = CFSetCreateMutable(NULL, 0, &kCFTypeSetCallBacks);
@@ -405 +403 @@
 
 #endif // APPLE_CHANGES
+
+} // namespace KJS