Changeset 2845 in webkit for trunk/JavaScriptCore/kjs/value.cpp

Timestamp:

Nov 23, 2002, 4:04:08 PM (23 years ago)

Author:

mjs

Message:

Numerous collector changes for a net gain of 3% on JS ibench:

• Replaced per-block bitmap with free list.
• Increased number of empty blocks kept around to 2.
• Doubled block size.
• When scanning heap in collector, skip scanning the rest of a block as soon as we see as many live cells as the the number of used cells it had originally.

Also the following collector changes unrelated to performance:

• Made constants const int' instead of static const int'.
• Miscellaneous code cleanup.

• kjs/collector.cpp:

• Added debugging mode enabled by defining DEBUG_GC which asserts when a destroyed ValueImp

• kjs/internal.cpp: (ContextImp::mark):
• kjs/value.cpp: (Value::Value):
• kjs/value.h:
• kjs/config.h:

File:

• trunk/JavaScriptCore/kjs/value.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/value.cpp

@@ -202 +202 @@
 {
   rep = v;
+#if DEBUG_COLLECTOR
+  assert (!(rep && !SimpleNumber::is(rep) && *((uint32_t *)rep) == 0 ));
+  assert (!(rep && !SimpleNumber::is(rep) && rep->_flags & VI_MARKED));
+#endif
   if (v)
   {
@@ -213 +217 @@
 {
   rep = v.imp();
+#if DEBUG_COLLECTOR
+  assert (!(rep && !SimpleNumber::is(rep) && *((uint32_t *)rep) == 0 ));
+  assert (!(rep && !SimpleNumber::is(rep) && rep->_flags & VI_MARKED));
+#endif
   if (rep)
   {