Ignore:
Timestamp:
Dec 5, 2007, 6:31:41 PM (17 years ago)
Author:
[email protected]
Message:

JavaScriptCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and
functions accessing data members from Interpreter to JSGlobalObject.
Changed Interpreter member functions to static functions.


This resolves a bug in global object bootstrapping, where the global
ExecState could be used when uninitialized.


This is a big change, but it's mostly code motion and renaming.


Layout and JS tests, and testjsglue and testapi, pass. SunSpider reports
a .7% regression, but Shark sees no difference related to this patch,
and SunSpider reported a .7% speedup from an earlier step in this
refactoring, so I think it's fair to call that a wash.

JavaScriptGlue:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Replaced JSInterpreter
subclass with JSGlobalObject subclass.


  • JSRun.cpp: (JSRun::JSRun): (JSRun::Evaluate): (JSRun::CheckSyntax):
  • JSRun.h: (JSGlueGlobalObject::JSGlueGlobalObject):
  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (getThreadGlobalExecState):

WebCore:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject. Changed Interpreter
member functions to static functions. Same for the subclass,
ScriptInterpreter.


This is a big change, but it's mostly code motion and renaming.

WebKit/mac:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.


  • WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]):

WebKit/win:

Reviewed by Darin Adler.

Third step in refactoring JSGlobalObject: Moved data members and data
member access from Interpreter to JSGlobalObject.


  • WebFrame.cpp: (WebFrame::globalContext): (WebFrame::attachScriptDebugger): (WebFrame::windowObjectCleared):
  • WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/JavaScriptCore.exp

    r28328 r28468  
    113113__ZN3KJS10throwErrorEPNS_9ExecStateENS_9ErrorTypeE
    114114__ZN3KJS10throwErrorEPNS_9ExecStateENS_9ErrorTypeEPKc
    115 __ZN3KJS11Interpreter11checkSyntaxERKNS_7UStringEiPKNS_5UCharEi
    116 __ZN3KJS11Interpreter11checkSyntaxERKNS_7UStringEiS3_
    117 __ZN3KJS11Interpreter15restoreBuiltinsERKNS_13SavedBuiltinsE
    118 __ZN3KJS11Interpreter15setGlobalObjectEPNS_14JSGlobalObjectE
    119 __ZN3KJS11Interpreter16stopTimeoutCheckEv
    120 __ZN3KJS11Interpreter17startTimeoutCheckEv
     115__ZN3KJS11Interpreter11checkSyntaxEPNS_9ExecStateERKNS_7UStringEiPKNS_5UCharEi
    121116__ZN3KJS11Interpreter21shouldPrintExceptionsEv
    122117__ZN3KJS11Interpreter24setShouldPrintExceptionsEb
    123 __ZN3KJS11Interpreter27resetGlobalObjectPropertiesEv
    124 __ZN3KJS11Interpreter6s_hookE
    125 __ZN3KJS11Interpreter8evaluateERKNS_7UStringEiPKNS_5UCharEiPNS_7JSValueE
    126 __ZN3KJS11Interpreter8evaluateERKNS_7UStringEiS3_PNS_7JSValueE
    127 __ZN3KJS11InterpreterC1Ev
    128 __ZN3KJS11InterpreterC2Ev
    129 __ZN3KJS11InterpreterD1Ev
    130 __ZN3KJS11InterpreterD2Ev
     118__ZN3KJS11Interpreter8evaluateEPNS_9ExecStateERKNS_7UStringEiPKNS_5UCharEiPNS_7JSValueE
     119__ZN3KJS11Interpreter8evaluateEPNS_9ExecStateERKNS_7UStringEiS5_PNS_7JSValueE
    131120__ZN3KJS11JSImmediate4typeEPKNS_7JSValueE
    132121__ZN3KJS11JSImmediate8toObjectEPKNS_7JSValueEPNS_9ExecStateE
    … …  
    140129__ZN3KJS12jsNumberCellEd
    141130__ZN3KJS13ArrayInstance4infoE
    142 __ZN3KJS13SavedBuiltinsC1Ev
    143 __ZN3KJS13SavedBuiltinsD1Ev
    144131__ZN3KJS13jsOwnedStringERKNS_7UStringE
    145132__ZN3KJS14JSGlobalObject10globalExecEv
     133__ZN3KJS14JSGlobalObject15restoreBuiltinsERKNS_13SavedBuiltinsE
     134__ZN3KJS14JSGlobalObject16stopTimeoutCheckEv
     135__ZN3KJS14JSGlobalObject17startTimeoutCheckEv
     136__ZN3KJS14JSGlobalObject4initEv
    146137__ZN3KJS14JSGlobalObject4markEv
     138__ZN3KJS14JSGlobalObject5resetEPNS_7JSValueE
     139__ZN3KJS14JSGlobalObject6s_headE
     140__ZN3KJS14JSGlobalObjectD2Ev
    147141__ZN3KJS14StringInstance14deletePropertyEPNS_9ExecStateERKNS_10IdentifierE
    148142__ZN3KJS14StringInstance16getPropertyNamesEPNS_9ExecStateERNS_17PropertyNameArrayE
    … …  
    193187__ZN3KJS8Bindings23convertObjcValueToValueEPNS_9ExecStateEPvNS0_13ObjcValueTypeEPNS0_10RootObjectE
    194188__ZN3KJS8Bindings23convertValueToObjcValueEPNS_9ExecStateEPNS_7JSValueENS0_13ObjcValueTypeE
     189__ZN3KJS8Bindings24findProtectingRootObjectEPNS_8JSObjectE
    195190__ZN3KJS8Bindings8Instance18didExecuteFunctionEv
    196191__ZN3KJS8Bindings8Instance21setDidExecuteFunctionEPFvPNS_9ExecStateEPNS_8JSObjectEE
    197192__ZN3KJS8Bindings8Instance32createBindingForLanguageInstanceENS1_15BindingLanguageEPvN3WTF10PassRefPtrINS0_10RootObjectEEE
    198193__ZN3KJS8Debugger12sourceUnusedEPNS_9ExecStateEi
    199 __ZN3KJS8Debugger6attachEPNS_11InterpreterE
     194__ZN3KJS8Debugger6attachEPNS_14JSGlobalObjectE
    200195__ZN3KJS8Debugger9exceptionEPNS_9ExecStateEiiPNS_7JSValueE
    201196__ZN3KJS8DebuggerC2Ev
    … …  
    220215__ZN3KJS8jsStringEPKc
    221216__ZN3KJS8jsStringERKNS_7UStringE
    222 __ZN3KJS9Collector15numInterpretersEv
    223217__ZN3KJS9Collector15recordExtraCostEm
     218__ZN3KJS9Collector16numGlobalObjectsEv
    224219__ZN3KJS9Collector19numProtectedObjectsEv
    225220__ZN3KJS9Collector20rootObjectTypeCountsEv
    … …  
    229224__ZN3KJS9Collector7protectEPNS_7JSValueE
    230225__ZN3KJS9Collector9unprotectEPNS_7JSValueE
     226__ZN3KJS9ExecStateD1Ev
    231227__ZN3KJSeqERKNS_7UStringEPKc
    232228__ZN3WTF10fastCallocEmm
    … …  
    235231__ZN3WTF16fastZeroedMallocEm
    236232__ZN3WTF8fastFreeEPv
    237 __ZNK3KJS11Interpreter12builtinArrayEv
    238 __ZNK3KJS11Interpreter12globalObjectEv
    239 __ZNK3KJS11Interpreter12saveBuiltinsERNS_13SavedBuiltinsE
    240 __ZNK3KJS11Interpreter15builtinFunctionEv
    241 __ZNK3KJS11Interpreter22builtinObjectPrototypeEv
    242 __ZNK3KJS11Interpreter22builtinStringPrototypeEv
    243 __ZNK3KJS11Interpreter24builtinFunctionPrototypeEv
    244233__ZNK3KJS11PropertyMap3getERKNS_10IdentifierE
    245234__ZNK3KJS11PropertyMap4saveERNS_15SavedPropertiesE
    246235__ZNK3KJS12DateInstance7getTimeERdRi
    247236__ZNK3KJS13ArrayInstance7getItemEj
     237__ZNK3KJS14JSGlobalObject12saveBuiltinsERNS_13SavedBuiltinsE
    248238__ZNK3KJS19InternalFunctionImp14implementsCallEv
    249239__ZNK3KJS19InternalFunctionImp21implementsHasInstanceEv
    … …  
    267257__ZNK3KJS7UString8toUInt32EPb
    268258__ZNK3KJS7UString8toUInt32EPbb
    269 __ZNK3KJS8Bindings10RootObject11interpreterEv
    270259__ZNK3KJS8Bindings10RootObject12globalObjectEv
    271260__ZNK3KJS8Bindings8Instance10rootObjectEv
    … …  
    285274__ZNK3KJS8JSObject9classNameEv
    286275__ZNK3KJS8JSObject9toBooleanEPNS_9ExecStateE
    287 __ZNK3KJS9ExecState18lexicalInterpreterEv
     276__ZNK3KJS9ExecState19lexicalGlobalObjectEv
    288277__ZTVN3KJS14JSGlobalObjectE
    289278__ZTVN3KJS14StringInstanceE
Note: See TracChangeset for help on using the changeset viewer.