Changeset 2851 in webkit for trunk/JavaScriptCore/kjs/interpreter.h

Timestamp:

Nov 24, 2002, 2:37:44 PM (23 years ago)

Author:

darin

Message:

JavaScriptCore:

• changed ScopeChain to not ref each item in the chain, and use marking instead; gains 1% on JavaScript iBench

• kjs/context.h: Return chain by reference.
• kjs/internal.cpp: (ContextImp::mark): Mark the scope chain.
• kjs/interpreter.cpp: (Context::scopeChain): Return chain by reference.
• kjs/interpreter.h: Make some Context methods inline.
• kjs/nodes.cpp: (ThisNode::evaluate): Get at ContextImp directly. (ResolveNode::evaluateReference): Ditto. (VarDeclNode::evaluate): Ditto. (VarDeclNode::processVarDecls): Ditto. (FuncDeclNode::processFuncDecl): Pass ScopeChain directly to avoid copying. (FuncExprNode::evaluate): Ditto.
• kjs/object.cpp: Make scope and setScope inline.
• kjs/object.h: Make scope return a chain by reference. Make scope and setScope both be inline. Use a normal ScopeChain instead of NoRefScopeChain since they are now one and the same.
• kjs/scope_chain.cpp: Remove all the code to ref and deref objects. Merge NoRefScopeChain in with ScopeChain since they both work this way now.
• kjs/scope_chain.h: Remove NoRefScopeChain and simplify the ref counts. Make more functions inline.

WebCore:

• force-js-clean-timestamp: Touch for ScopeChain change.

File:

• trunk/JavaScriptCore/kjs/interpreter.h (modified) (4 diffs)

trunk/JavaScriptCore/kjs/interpreter.h

@@ -54 +54 @@
   class Context {
   public:
-    Context(ContextImp *);
-    Context(const Context &c);
-    Context& operator=(const Context &c);
-    virtual ~Context();
-
-    bool isNull() const;
-    ContextImp *imp() const;
+    Context(ContextImp *i) : rep(i) { }
+
+    ContextImp *imp() const { return rep; }
 
     /**
@@ -69 +65 @@
      * @return The execution context's scope chain
      */
-    const ScopeChain scopeChain() const;
+    const ScopeChain &scopeChain() const;
 
     /**
@@ -105 +101 @@
      */
     const Context callingContext() const;
+
   private:
     ContextImp *rep;
@@ -380 +377 @@
      * @return The current execution state context
      */
-    const Context context() const { return _context; }
+    Context context() const { return _context; }
 
     void setException(const Value &e) { _exception = e; }