Changeset 286155 in webkit for trunk/Source/JavaScriptCore/assembler/MacroAssembler.h

Timestamp:

Nov 24, 2021, 4:32:30 PM (4 years ago)

Author:

[email protected]

Message:

MacroAssembler: remove unused load/store methods for addresses with patchable offsets
​https://bugs.webkit.org/show_bug.cgi?id=233251

Patch by Zan Dobersek <​[email protected]> on 2021-11-24
Reviewed by Yusuke Suzuki.

Remove MacroAssembler methods for load and store operations on addresses
with patchable offset values as they're not used in any place anymore.

• assembler/MacroAssembler.h:

(JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): Deleted.
(JSC::MacroAssembler::loadPtrWithCompactAddressOffsetPatch): Deleted.
(JSC::MacroAssembler::storePtrWithAddressOffsetPatch): Deleted.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::load32WithAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerARM64::load32WithCompactAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerARM64::store32WithAddressOffsetPatch): Deleted.

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load32WithAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerARMv7::load32WithCompactAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerARMv7::store32WithAddressOffsetPatch): Deleted.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerMIPS::load32WithCompactAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch): Deleted.

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerX86Common::load32WithCompactAddressOffsetPatch): Deleted.
(JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch): Deleted.

File:

• trunk/Source/JavaScriptCore/assembler/MacroAssembler.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/assembler/MacroAssembler.h

@@ -736 +736 @@
 #endif
 
-    DataLabel32 loadPtrWithAddressOffsetPatch(Address address, RegisterID dest)
-    {
-        return load32WithAddressOffsetPatch(address, dest);
-    }
-    
-    DataLabelCompact loadPtrWithCompactAddressOffsetPatch(Address address, RegisterID dest)
-    {
-        return load32WithCompactAddressOffsetPatch(address, dest);
-    }
-    
     void comparePtr(RelationalCondition cond, RegisterID left, TrustedImm32 right, RegisterID dest)
     {
@@ -794 +784 @@
     {
         store32(TrustedImm32(imm), address);
-    }
-
-    DataLabel32 storePtrWithAddressOffsetPatch(RegisterID src, Address address)
-    {
-        return store32WithAddressOffsetPatch(src, address);
     }
 
@@ -1089 +1074 @@
 #endif
 
-    DataLabel32 loadPtrWithAddressOffsetPatch(Address address, RegisterID dest)
-    {
-        return load64WithAddressOffsetPatch(address, dest);
-    }
-    
-    DataLabelCompact loadPtrWithCompactAddressOffsetPatch(Address address, RegisterID dest)
-    {
-        return load64WithCompactAddressOffsetPatch(address, dest);
-    }
-
     void storePtr(RegisterID src, Address address)
     {
@@ -1127 +1102 @@
     {
         store64(TrustedImm64(imm), address);
-    }
-
-    DataLabel32 storePtrWithAddressOffsetPatch(RegisterID src, Address address)
-    {
-        return store64WithAddressOffsetPatch(src, address);
     }