Changeset 28635 in webkit for trunk/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

Timestamp:

Dec 11, 2007, 4:30:04 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin Adler.

Fixed: All JS tests crash on Windows.

NDEBUG wasn't defined when compiling testkjs in release builds, so the
HashTable definition in HashTable.h included an extra data member.

The solution was to add NDEBUG to the release testkjs configuration on
Windows and Mac.

For giggles, I also added other missing #defines to testkjs on Windows.

• Configurations/Base.xcconfig:
• Configurations/JavaScriptCore.xcconfig:
• JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/testkjs.cpp: (main):

File:

• trunk/JavaScriptCore/Configurations/JavaScriptCore.xcconfig (modified) (1 diff)

trunk/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

@@ -9 +9 @@
 OTHER_LDFLAGS = -lobjc -sub_library libobjc -Wl,-Y,3;
 GCC_PREFIX_HEADER = JavaScriptCorePrefix.h;
-GCC_PREPROCESSOR_DEFINITIONS = $(DEBUG_DEFINES) $(GCC_PREPROCESSOR_DEFINITIONS);
 HEADER_SEARCH_PATHS = "${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore" $(HEADER_SEARCH_PATHS);
 INFOPLIST_FILE = Info.plist;