Ignore:
Timestamp:
Dec 11, 2007, 4:30:04 PM (17 years ago)
Author:
[email protected]
Message:

Reviewed by Darin Adler.


Fixed: All JS tests crash on Windows.

NDEBUG wasn't defined when compiling testkjs in release builds, so the
HashTable definition in HashTable.h included an extra data member.

The solution was to add NDEBUG to the release testkjs configuration on
Windows and Mac.


For giggles, I also added other missing #defines to testkjs on Windows.

  • Configurations/Base.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/testkjs.cpp: (main):
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r28527 r28635  
    16821682                        baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* JavaScriptCore.xcconfig */;
    16831683                        buildSettings = {
    1684                                 DEBUG_DEFINES = "";
    16851684                                INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
    16861685                        };
    … …  
    16911690                        baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* JavaScriptCore.xcconfig */;
    16921691                        buildSettings = {
    1693                                 DEBUG_DEFINES = NDEBUG;
    16941692                                INSTALL_PATH = "$(BUILT_PRODUCTS_DIR)";
    16951693                        };
    … …  
    17001698                        baseConfigurationReference = 1C9051430BA9E8A70081E9D0 /* JavaScriptCore.xcconfig */;
    17011699                        buildSettings = {
    1702                                 DEBUG_DEFINES = NDEBUG;
    17031700                                SECTORDER_FLAGS = (
    17041701                                        "-sectorder",
    … …  
    17561753                        baseConfigurationReference = 1C9051440BA9E8A70081E9D0 /* DebugRelease.xcconfig */;
    17571754                        buildSettings = {
     1755                                DEBUG_DEFINES = "";
    17581756                                GCC_OPTIMIZATION_LEVEL = 0;
    17591757                                STRIP_INSTALLED_PRODUCT = NO;
    … …  
    17651763                        baseConfigurationReference = 1C9051440BA9E8A70081E9D0 /* DebugRelease.xcconfig */;
    17661764                        buildSettings = {
     1765                                DEBUG_DEFINES = NDEBUG;
    17671766                                STRIP_INSTALLED_PRODUCT = NO;
    17681767                        };
    … …  
    17731772                        baseConfigurationReference = 1C9051450BA9E8A70081E9D0 /* Base.xcconfig */;
    17741773                        buildSettings = {
     1774                                DEBUG_DEFINES = NDEBUG;
    17751775                        };
    17761776                        name = Production;
Note: See TracChangeset for help on using the changeset viewer.