Changeset 286916 in webkit for trunk/Source/WebCore/css/CSSMediaRule.h

Timestamp:

Dec 11, 2021, 10:28:39 AM (3 years ago)

Author:

Antti Koivisto

Message:

Remove redundant StyleRule::Type enum
​https://bugs.webkit.org/show_bug.cgi?id=234156

Reviewed by Alan Bujtas.

Source/WebCore:

Remove redundant CSSRule::STYLE_RULE etc enum values and just use StyleRuleType enum class.

• bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJSNewlyCreated):

• bindings/scripts/CodeGenerator.pm:

(GenerateCompileTimeCheckForEnumsIfNeeded):

Add 'ConstantsEnum' attribute to generate static_asserts for constants that match an enum class.

• bindings/scripts/IDLAttributes.json:
• css/CSSCounterStyleRule.h:
• css/CSSFontFaceRule.h:
• css/CSSFontPaletteValuesRule.h:
• css/CSSImportRule.h:
• css/CSSKeyframeRule.h:
• css/CSSKeyframesRule.h:
• css/CSSLayerBlockRule.h:
• css/CSSLayerStatementRule.h:
• css/CSSMediaRule.h:
• css/CSSNamespaceRule.h:
• css/CSSPageRule.h:
• css/CSSRule.cpp:
• css/CSSRule.h:

(WebCore::CSSRule::typeForBindings const):

• css/CSSRule.idl:
• css/CSSStyleRule.h:
• css/CSSSupportsRule.h:
• css/CSSUnknownRule.h:
• css/StyleRuleType.h:
• style/InspectorCSSOMWrappers.cpp:

(WebCore::Style::InspectorCSSOMWrappers::collect):

Source/WebKitLegacy/mac:

• DOM/DOMCSS.mm:

(kitClass):

• DOM/DOMCSSRule.mm:

(-[DOMCSSRule type]):

File:

• trunk/Source/WebCore/css/CSSMediaRule.h (modified) (2 diffs)

trunk/Source/WebCore/css/CSSMediaRule.h

@@ -41 +41 @@
     CSSMediaRule(StyleRuleMedia&, CSSStyleSheet*);
 
-    CSSRule::Type type() const final { return MEDIA_RULE; }
+    StyleRuleType styleRuleType() const final { return StyleRuleType::Media; }
     void reattach(StyleRuleBase&) final;
     String cssText() const final;
@@ -54 +54 @@
 } // namespace WebCore
 
-SPECIALIZE_TYPE_TRAITS_CSS_RULE(CSSMediaRule, CSSRule::MEDIA_RULE)
+SPECIALIZE_TYPE_TRAITS_CSS_RULE(CSSMediaRule, StyleRuleType::Media)