Changeset 286920 in webkit for trunk/Source/JavaScriptCore/jit/PCToCodeOriginMap.h

Timestamp:

Dec 11, 2021, 4:39:57 PM (3 years ago)

Author:

[email protected]

Message:

Teach the sampling profiler how to display origin data for B3 Wasm
​https://bugs.webkit.org/show_bug.cgi?id=234097

Reviewed by Yusuke Suzuki.

This teaches the SamplingProfiler how to gather origin data for
Wasm. We reuse the PCToCodeOriginMap from JS, and store the wasm
function offset data inside of CodeOrigin's BytecodeIndex.

For now, this patch is only doing this for B3, because the Air backend
doesn't currently generate filled in OpcodeOrigin data. We'll fix that
in: ​https://bugs.webkit.org/show_bug.cgi?id=234182

Also, this capability isn't yet supported in Web Inspector. We'll want
to do that in a future change as we improve Web Inspector's ability to
debug Wasm code. When that time comes, we'll have to generate the
PCToCodeOriginMap based on debugging info, and not just 'useSamplingProfiler'
JSC option.

The data now shows up like this for hottest bytecodes:

Hottest bytecodes as <numSamples 'functionName#hash:JITType:bytecodeIndex'>

524 '<?>.wasm-function[2373]:OMG:0x21a'
414 '<?>.wasm-function[2363]:OMG:0x1ae'
395 '<?>.wasm-function[2373]:OMG:0x418'
354 '<?>.wasm-function[2373]:OMG:0x34f'
270 '<?>.wasm-function[2373]:OMG:0x352'
256 '<?>.wasm-function[2363]:OMG:0x152'

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• jit/PCToCodeOriginMap.cpp:

(JSC::PCToCodeOriginMapBuilder::PCToCodeOriginMapBuilder):

• jit/PCToCodeOriginMap.h:
• runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::recordJITFrame):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::reportTopBytecodes):

• runtime/SamplingProfiler.h:
• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::origin):
(JSC::Wasm::parseAndCompileAir):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile):
(JSC::Wasm::computePCToCodeOriginMap):

• wasm/WasmB3IRGenerator.h:

(): Deleted.

• wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::work):
(JSC::Wasm::BBQPlan::didCompleteCompilation):
(JSC::Wasm::BBQPlan::initializeCallees):

• wasm/WasmCalleeRegistry.h:

(JSC::Wasm::CalleeRegistry::unregisterCallee):
(JSC::Wasm::CalleeRegistry::addPCToCodeOriginMap):
(JSC::Wasm::CalleeRegistry::WTF_REQUIRES_LOCK):

• wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

• wasm/WasmOpcodeOrigin.h:

(JSC::Wasm::OpcodeOrigin::OpcodeOrigin):

File:

• trunk/Source/JavaScriptCore/jit/PCToCodeOriginMap.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/jit/PCToCodeOriginMap.h

@@ -54 +54 @@
 
 #if ENABLE(FTL_JIT)
-    PCToCodeOriginMapBuilder(VM&, B3::PCToOriginMap&&);
+    enum JSTag { JSCodeOriginMap };
+    PCToCodeOriginMapBuilder(JSTag, VM&, B3::PCToOriginMap);
+#endif
+
+#if ENABLE(WEBASSEMBLY_B3JIT)
+    enum WasmTag { WasmCodeOriginMap };
+    PCToCodeOriginMapBuilder(WasmTag, B3::PCToOriginMap);
 #endif
 
@@ -70 +76 @@
     };
 
-    VM& m_vm;
     Vector<CodeRange> m_codeRanges;
     bool m_shouldBuildMapping;