Changeset 287531 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Jan 2, 2022, 11:39:38 PM (3 years ago)

Author:

[email protected]

Message:

[JSC] Use emitPutProperty / emitGetPropertyValue consistently to handle private names in edge cases
​https://bugs.webkit.org/show_bug.cgi?id=234794

Reviewed by Alexey Shvayka.

JSTests:

• test262/expectations.yaml:

Source/JavaScriptCore:

This patch consistently uses emitPutProperty / emitGetPropertyValue so that we handle private names
in edge cases.

• bytecompiler/NodesCodegen.cpp:

(JSC::TaggedTemplateNode::emitBytecode):
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
(JSC::AssignmentElementNode::bindValue const):

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -1562 +1562 @@
     };
 
-    class ShortCircuitReadModifyDotNode final : public ExpressionNode, public ThrowableSubExpressionData {
-    public:
-        ShortCircuitReadModifyDotNode(const JSTokenLocation&, ExpressionNode* base, const Identifier&, Operator, ExpressionNode* right, bool rightHasAssignments, const JSTextPosition& divot, const JSTextPosition& divotStart, const JSTextPosition& divotEnd);
-
-    private:
-        RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = nullptr) final;
-
-        ExpressionNode* m_base;
-        const Identifier& m_ident;
+    class ShortCircuitReadModifyDotNode final : public BaseDotNode, public ThrowableSubExpressionData {
+    public:
+        ShortCircuitReadModifyDotNode(const JSTokenLocation&, ExpressionNode* base, const Identifier&, DotType, Operator, ExpressionNode* right, bool rightHasAssignments, const JSTextPosition& divot, const JSTextPosition& divotStart, const JSTextPosition& divotEnd);
+
+    private:
+        RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = nullptr) final;
+
         ExpressionNode* m_right;
         Operator m_operator;