Changeset 287762 in webkit for trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

Timestamp:

Jan 7, 2022, 10:48:40 AM (3 years ago)

Author:

[email protected]

Message:

Expose iterators on AnimationList
​https://bugs.webkit.org/show_bug.cgi?id=234957

Reviewed by Antti Koivisto.

• animation/WebAnimationUtilities.cpp:

(WebCore::compareCSSAnimations):

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueListForAnimationOrTransitionProperty):
(WebCore::animationShorthandValue):

• css/makeprop.pl:

(generateAnimationPropertyInitialValueSetter):

• platform/animation/AnimationList.h:

(WebCore::AnimationList::begin const):
(WebCore::AnimationList::end const):
(WebCore::AnimationList::rbegin const):
(WebCore::AnimationList::rend const):

• style/Styleable.cpp:

(WebCore::Styleable::updateCSSAnimations const):
(WebCore::compileTransitionPropertiesInStyle):
(WebCore::updateCSSTransitionsForStyleableAndProperty):

File:

• trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (2 diffs)

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -1475 +1475 @@
     auto list = CSSValueList::createCommaSeparated();
     if (animationList) {
-        for (size_t i = 0; i < animationList->size(); ++i)
-            ComputedStyleExtractor::addValueForAnimationPropertyToList(list.get(), property, &animationList->animation(i));
+        for (const auto& animation : *animationList)
+            ComputedStyleExtractor::addValueForAnimationPropertyToList(list.get(), property, animation.ptr());
     } else
         ComputedStyleExtractor::addValueForAnimationPropertyToList(list.get(), property, nullptr);
@@ -1486 +1486 @@
     auto parentList = CSSValueList::createCommaSeparated();
     if (animationList) {
-        for (size_t i = 0; i < animationList->size(); ++i) {
-            const auto& animation = animationList->animation(i);
+        for (const auto& animation : *animationList) {
             auto childList = CSSValueList::createSpaceSeparated();
             for (auto longhand : shorthandForProperty(property))
-                ComputedStyleExtractor::addValueForAnimationPropertyToList(childList.get(), longhand, &animation);
+                ComputedStyleExtractor::addValueForAnimationPropertyToList(childList.get(), longhand, animation.ptr());
             parentList->append(childList);
         }