Changeset 288268 in webkit for trunk/Source/JavaScriptCore/offlineasm/cloop.rb

Timestamp:

Jan 19, 2022, 8:03:12 PM (3 years ago)

Author:

[email protected]

Message:

[JSC] Fix non-JIT Windows LLInt
​https://bugs.webkit.org/show_bug.cgi?id=235388

Reviewed by Mark Lam.

We should implement cCall3 which calls llint_link_call etc. from LLInt code.
This implementation needs to work on Windows too, so it requires stack modification.
While we do not have a problem on JIT Windows build, it is required for non JIT Windows
build. (If JIT is enabled, LLInt is fine. But if JIT is entirely disabled, this change
is required.)

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_link_call):
(JSC::LLInt::llint_virtual_call):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• offlineasm/cloop.rb:
• offlineasm/instructions.rb:

File:

• trunk/Source/JavaScriptCore/offlineasm/cloop.rb (modified) (2 diffs)

trunk/Source/JavaScriptCore/offlineasm/cloop.rb

@@ -571 +571 @@
     $asm.putc "cloopStack.setCurrentStackPointer(sp.vp());"
     $asm.putc "#{operands[0].cLabel}(#{operands[1].clDump}, #{operands[2].clDump});"
+end
+
+def cloopEmitCallSlowPath3(operands)
+    $asm.putc "{"
+    $asm.putc "    cloopStack.setCurrentStackPointer(sp.vp());"
+    $asm.putc "    SlowPathReturnType result = #{operands[0].cLabel}(#{operands[1].clDump}, #{operands[2].clDump}, #{operands[3].clDump});"
+    $asm.putc "    decodeResult(result, t0, t1);"
+    $asm.putc "}"
 end
 
@@ -1184 +1192 @@
             cloopEmitCallSlowPathVoid(operands)
 
+        when "cloopCallSlowPath3"
+            cloopEmitCallSlowPath3(operands)
+
         when "cloopCallSlowPath4"
             cloopEmitCallSlowPath4(operands)