Changeset 28935 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Dec 21, 2007, 7:36:13 AM (17 years ago)

Author:

Darin Adler

Message:

• fix broken regression tests

The broken tests were fast/js/do-while-expression-value.html and
fast/js/while-expression-value.html.

• kjs/nodes.cpp: Check in the correct version of this file. I had accidentally landed an old version of my patch for bug 16471. (KJS::statementListExecute): The logic here was backwards. Have to set the value even for non-normal execution results.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -3595 +3595 @@
     for (size_t i = 0; i != size; ++i) {
         JSValue* statementValue = statements[i]->execute(exec);
-        if (exec->completionType() != Normal)
-            return statementValue;
         if (statementValue)
             value = statementValue;
+        if (exec->completionType() != Normal)
+            return value;
     }
     return exec->setNormalCompletion(value);