Changeset 289417 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Feb 8, 2022, 12:42:04 PM (3 years ago)

Author:

[email protected]

Message:

[JSC] move function wrapping logic to a new Function type
​https://bugs.webkit.org/show_bug.cgi?id=235382

Reviewed by Yusuke Suzuki.

JSTests:

Adds a new file testing CopyNameAndLength stuff in the ShadowRealm proposal,
and fix up assertions about this in shadow-realm-evaluate.js

• stress/shadow-realm-evaluate.js:
• stress/shadow-realm-remote-function-copy-length-and-name.js: Added.

Source/JavaScriptCore:

In this initial patch, there is still a lot of JS-builtin machinery,
including some duplicated functionality. Additionally, JIT support
has not been incorporated yet.

Broadly, the idea is that there are custom hooks for calling a
JSRemoteFunction, which perform the wrapping functionality. This avoids
the need for allocating closures which contain the wrapping logic.

TODO:

• JIT/DFG/FTL support
• structure caching (unnecessary since these are not constructors?)
• improved baseline perf

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• assembler/LinkBuffer.h:
• builtins/BuiltinNames.h:
• builtins/ShadowRealmPrototype.js:
• bytecode/LinkTimeConstant.h:
• dfg/DFGSpeculativeJIT.cpp:
• ftl/FTLLowerDFGToB3.cpp:
• heap/Heap.cpp:
• heap/Heap.h:
• inspector/JSInjectedScriptHost.cpp:
• interpreter/Interpreter.cpp:
• jit/AssemblyHelpers.h:
• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/ThunkGenerators.cpp:
• jit/ThunkGenerators.h:
• jsc.cpp:
• runtime/ErrorInstance.cpp:
• runtime/FunctionPrototype.cpp:
• runtime/InternalFunction.cpp:
• runtime/Intrinsic.cpp:
• runtime/Intrinsic.h:
• runtime/JSCast.h:
• runtime/JSFunction.cpp:
• runtime/JSFunction.h:
• runtime/JSFunctionInlines.h:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h:
• runtime/JSRemoteFunction.cpp: Added.
• runtime/JSRemoteFunction.h: Added.
• runtime/VM.cpp:
• runtime/VM.h:

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (4 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -50 +50 @@
 #include "JSFinalizationRegistry.h"
 #include "JSFunction.h"
+#include "JSFunctionInlines.h"
 #include "JSInternalPromise.h"
 #include "JSLock.h"
@@ -367 +368 @@
 static JSC_DECLARE_HOST_FUNCTION(functionDollarClearKeptObjects);
 static JSC_DECLARE_HOST_FUNCTION(functionDollarGlobalObjectFor);
+static JSC_DECLARE_HOST_FUNCTION(functionDollarIsRemoteFunction);
 static JSC_DECLARE_HOST_FUNCTION(functionDollarAgentStart);
 static JSC_DECLARE_HOST_FUNCTION(functionDollarAgentReceiveBroadcast);
@@ -650 +652 @@
         addFunction(vm, dollar, "clearKeptObjects", functionDollarClearKeptObjects, 0, static_cast<unsigned>(PropertyAttribute::None));
         addFunction(vm, dollar, "globalObjectFor", functionDollarGlobalObjectFor, 1, static_cast<unsigned>(PropertyAttribute::None));
+        addFunction(vm, dollar, "isRemoteFunction", functionDollarIsRemoteFunction, 1, static_cast<unsigned>(PropertyAttribute::None));
         
         dollar->putDirect(vm, Identifier::fromString(vm, "global"), globalThis());
@@ -2083 +2086 @@
 
     return JSValue::encode(jsUndefined());
+}
+
+JSC_DEFINE_HOST_FUNCTION(functionDollarIsRemoteFunction, (JSGlobalObject* globalObject, CallFrame* callFrame))
+{
+    VM& vm = globalObject->vm();
+    auto scope = DECLARE_THROW_SCOPE(vm);
+
+    if (callFrame->argumentCount() < 1)
+        return JSValue::encode(throwException(globalObject, scope, createError(globalObject, "Not enough arguments"_s)));
+
+    JSValue arg = callFrame->argument(0);
+    return JSValue::encode(jsBoolean(isRemoteFunction(vm, arg)));
 }