Changeset 289417 in webkit for trunk/Source/JavaScriptCore/runtime/VM.cpp

Timestamp:

Feb 8, 2022, 12:42:04 PM (3 years ago)

Author:

[email protected]

Message:

[JSC] move function wrapping logic to a new Function type
​https://bugs.webkit.org/show_bug.cgi?id=235382

Reviewed by Yusuke Suzuki.

JSTests:

Adds a new file testing CopyNameAndLength stuff in the ShadowRealm proposal,
and fix up assertions about this in shadow-realm-evaluate.js

• stress/shadow-realm-evaluate.js:
• stress/shadow-realm-remote-function-copy-length-and-name.js: Added.

Source/JavaScriptCore:

In this initial patch, there is still a lot of JS-builtin machinery,
including some duplicated functionality. Additionally, JIT support
has not been incorporated yet.

Broadly, the idea is that there are custom hooks for calling a
JSRemoteFunction, which perform the wrapping functionality. This avoids
the need for allocating closures which contain the wrapping logic.

TODO:

• JIT/DFG/FTL support
• structure caching (unnecessary since these are not constructors?)
• improved baseline perf

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Sources.txt:
• assembler/LinkBuffer.h:
• builtins/BuiltinNames.h:
• builtins/ShadowRealmPrototype.js:
• bytecode/LinkTimeConstant.h:
• dfg/DFGSpeculativeJIT.cpp:
• ftl/FTLLowerDFGToB3.cpp:
• heap/Heap.cpp:
• heap/Heap.h:
• inspector/JSInjectedScriptHost.cpp:
• interpreter/Interpreter.cpp:
• jit/AssemblyHelpers.h:
• jit/JITOperations.cpp:
• jit/JITOperations.h:
• jit/ThunkGenerators.cpp:
• jit/ThunkGenerators.h:
• jsc.cpp:
• runtime/ErrorInstance.cpp:
• runtime/FunctionPrototype.cpp:
• runtime/InternalFunction.cpp:
• runtime/Intrinsic.cpp:
• runtime/Intrinsic.h:
• runtime/JSCast.h:
• runtime/JSFunction.cpp:
• runtime/JSFunction.h:
• runtime/JSFunctionInlines.h:
• runtime/JSGlobalObject.cpp:
• runtime/JSGlobalObject.h:
• runtime/JSRemoteFunction.cpp: Added.
• runtime/JSRemoteFunction.h: Added.
• runtime/VM.cpp:
• runtime/VM.h:

File:

• trunk/Source/JavaScriptCore/runtime/VM.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -633 +633 @@
     case BoundFunctionCallIntrinsic:
         return boundFunctionCallGenerator;
+    case RemoteFunctionCallIntrinsic:
+        return remoteFunctionCallGenerator;
     default:
         return nullptr;
@@ -708 +710 @@
         return getOrCreate(m_fastCanConstructBoundExecutable);
     return getOrCreate(m_fastBoundExecutable);
+}
+
+NativeExecutable* VM::getRemoteFunction(bool isJSFunction)
+{
+    bool slowCase = !isJSFunction;
+    auto getOrCreate = [&] (Weak<NativeExecutable>& slot) -> NativeExecutable* {
+        if (auto* cached = slot.get())
+            return cached;
+        NativeExecutable* result = getHostFunction(
+            slowCase ? remoteFunctionCallGeneric : remoteFunctionCallForJSFunction,
+            slowCase ? NoIntrinsic : RemoteFunctionCallIntrinsic,
+            callHostFunctionAsConstructor, nullptr, String());
+        slot = Weak<NativeExecutable>(result);
+        return result;
+    };
+
+    if (slowCase)
+        return getOrCreate(m_slowRemoteFunctionExecutable);
+    return getOrCreate(m_fastRemoteFunctionExecutable);
 }