Changeset 29059 in webkit for trunk/JavaScriptCore/kjs/Parser.h

Timestamp:

Jan 1, 2008, 12:43:59 AM (17 years ago)

Author:

Darin Adler

Message:

Reviewed by Oliver.

• ​http://bugs.webkit.org/show_bug.cgi?id=16684 eliminate debugger overhead from function body execution

Speeds SunSpider up 1.003x. That's a small amount, but measurable.

• JavaScriptCore.exp: Updated.
• kjs/Parser.h: (KJS::Parser::parse): Create the node with a static member function named create() instead of using new explicitly.

• kjs/grammar.y: Changed calls to new FunctionBodyNode to use FunctionBodyNode::create().

• kjs/nodes.cpp: (KJS::ProgramNode::create): Added. Calls new. (KJS::EvalNode::create): Ditto. (KJS::FunctionBodyNode::create): Ditto, but creates FunctionBodyNodeWithDebuggerHooks when a debugger is present. (KJS::FunctionBodyNode::execute): Removed debugger hooks. (KJS::FunctionBodyNodeWithDebuggerHooks::FunctionBodyNodeWithDebuggerHooks): Added. (KJS::FunctionBodyNodeWithDebuggerHooks::execute): Calls the debugger, then the code, then the debugger again.

• kjs/nodes.h: Added create functions, made the constructors private and protected.

File:

• trunk/JavaScriptCore/kjs/Parser.h (modified) (1 diff)

trunk/JavaScriptCore/kjs/Parser.h

@@ -85 +85 @@
             return 0;
         }
-        RefPtr<ParsedNode> node = new ParsedNode(m_sourceElements.release().get(),
-                                                 m_varDeclarations ? &m_varDeclarations->data : 0, 
-                                                 m_funcDeclarations ? &m_funcDeclarations->data : 0);
+        RefPtr<ParsedNode> node = ParsedNode::create(m_sourceElements.release().get(),
+                                                     m_varDeclarations ? &m_varDeclarations->data : 0, 
+                                                     m_funcDeclarations ? &m_funcDeclarations->data : 0);
         m_varDeclarations = 0;
         m_funcDeclarations = 0;