Changeset 291165 in webkit for trunk/Source/JavaScriptCore/wasm/WasmCompilationMode.h

Timestamp:

Mar 11, 2022, 6:27:16 AM (3 years ago)

Author:

Mikhail R. Gadelha

Message:

Debug build failure after r246172: ASSERT_UNDER_CONSTEXPR_CONTEXT should work in constexpr contexts
​https://bugs.webkit.org/show_bug.cgi?id=236728

Reviewed by Michael Catanzaro.

ASSERT_UNDER_CONSTEXPR_CONTEXT is calling a non-constexpr function (WTFReportAssertionFailure)
when it fails, so it cannot be used for an assert not reached.

This patch adds a new RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT() macro
that calls CRASH_UNDER_CONSTEXPR_CONTEXT() instead of WTFReportAssertionFailure.

No functional change.

• wasm/WasmCompilationMode.h:

(JSC::Wasm::isOSREntry):
(JSC::Wasm::isAnyBBQ):
(JSC::Wasm::isAnyOMG):

File:

• trunk/Source/JavaScriptCore/wasm/WasmCompilationMode.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/wasm/WasmCompilationMode.h

@@ -51 +51 @@
         return true;
     }
-    RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false);
+    RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT();
 }
 
@@ -66 +66 @@
         return false;
     }
-    RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false);
+    RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT();
 }
 
@@ -81 +81 @@
         return false;
     }
-    RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false);
+    RELEASE_ASSERT_NOT_REACHED_UNDER_CONSTEXPR_CONTEXT();
 }