Changeset 291332 in webkit for trunk/Source/JavaScriptCore/dfg/DFGGraph.cpp

Timestamp:

Mar 15, 2022, 10:35:12 PM (3 years ago)

Author:

[email protected]

Message:

[JSC] Add UnlinkedDFG compilation mode enum
​https://bugs.webkit.org/show_bug.cgi?id=237934

Reviewed by Mark Lam.

This patch adds UnlinkedDFG compilation mode to prepare new unlinked DFG.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inliningCost):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::watchCondition):
(JSC::DFG::Graph::watchConditions):
(JSC::DFG::Graph::watchGlobalProperty):
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::tryGetConstantClosureVar):
(JSC::DFG::Graph::tryGetFoldableView):
(JSC::DFG::Graph::getRegExpPrototypeProperty):
(JSC::DFG::Graph::canOptimizeStringObjectAccess):
(JSC::DFG::Graph::canDoFastSpread):

• dfg/DFGGraph.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

• jit/JITCompilationMode.cpp:

(WTF::printInternal):

• jit/JITCompilationMode.h:

(JSC::isDFG):
(JSC::isUnlinked):

• jit/JITPlan.cpp:

(JSC::JITPlan::tier const):
(JSC::JITPlan::reportCompileTimes const):

• jit/JITPlan.h:

(JSC::JITPlan::isDFG const):
(JSC::JITPlan::isUnlinked const):

• profiler/ProfilerCompilationKind.cpp:

(WTF::printInternal):

• profiler/ProfilerCompilationKind.h:

File:

• trunk/Source/JavaScriptCore/dfg/DFGGraph.cpp (modified) (9 diffs)

trunk/Source/JavaScriptCore/dfg/DFGGraph.cpp

@@ -1062 +1062 @@
 bool Graph::watchCondition(const ObjectPropertyCondition& key)
 {
+    if (m_plan.isUnlinked())
+        return false;
+
     if (!key.isWatchable())
         return false;
@@ -1082 +1085 @@
 bool Graph::watchConditions(const ObjectPropertyConditionSet& keys)
 {
+    if (m_plan.isUnlinked())
+        return false;
+
     if (!keys.isValid())
         return false;
@@ -1099 +1105 @@
 bool Graph::watchGlobalProperty(JSGlobalObject* globalObject, unsigned identifierNumber)
 {
+    if (m_plan.isUnlinked())
+        return false;
+
     UniquedStringImpl* uid = identifiers()[identifierNumber];
     // If we already have a WatchpointSet, and it is already invalidated, it means that this scope operation must be changed from GlobalProperty to GlobalLexicalVar,
@@ -1268 +1277 @@
     JSValue base, const RegisteredStructureSet& structureSet, PropertyOffset offset)
 {
+    if (m_plan.isUnlinked())
+        return JSValue();
+
     if (!base || !base.isObject())
         return JSValue();
@@ -1353 +1365 @@
 {
     // This has an awesome concurrency story. See comment for GetGlobalVar in ByteCodeParser.
+
+    if (m_plan.isUnlinked())
+        return JSValue();
     
     if (!base)
@@ -1403 +1418 @@
 JSArrayBufferView* Graph::tryGetFoldableView(JSValue value)
 {
+    if (m_plan.isUnlinked())
+        return nullptr;
     if (!value)
         return nullptr;
@@ -1731 +1748 @@
 bool Graph::getRegExpPrototypeProperty(JSObject* regExpPrototype, Structure* regExpPrototypeStructure, UniquedStringImpl* uid, JSValue& returnJSValue)
 {
+    if (m_plan.isUnlinked())
+        return false;
+
     PropertyOffset offset = regExpPrototypeStructure->getConcurrently(uid);
     if (!isValidOffset(offset))
@@ -1778 +1798 @@
 bool Graph::canOptimizeStringObjectAccess(const CodeOrigin& codeOrigin)
 {
+    if (m_plan.isUnlinked())
+        return false;
+
     if (hasExitSite(codeOrigin, BadCache) || hasExitSite(codeOrigin, BadConstantCache))
         return false;
@@ -1829 +1852 @@
     // The parameter 'value' is the AbstractValue for child1 (the thing being spread).
     ASSERT(node->op() == Spread);
+
+    if (m_plan.isUnlinked())
+        return false;
 
     if (node->child1().useKind() != ArrayUse) {