Changeset 291690 in webkit for trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

Timestamp:

Mar 22, 2022, 12:54:50 PM (3 years ago)

Author:

[email protected]

Message:

Unreviewed, reverting r291546.
​https://bugs.webkit.org/show_bug.cgi?id=238218

7% regression in Speedometer2/jQuery-TodoMVC

Reverted changeset:

"Fix CSS cascade regarding logical properties"
​https://bugs.webkit.org/show_bug.cgi?id=236199
​https://commits.webkit.org/r291546

File:

• trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (modified) (3 diffs)

trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -4035 +4035 @@
         case CSSPropertyBorderBlockColor:
             return getCSSPropertyValuesFor2SidesShorthand(borderBlockColorShorthand());
-        case CSSPropertyBorderBlockEnd:
-            return getCSSPropertyValuesForShorthandProperties(borderBlockEndShorthand());
-        case CSSPropertyBorderBlockStart:
-            return getCSSPropertyValuesForShorthandProperties(borderBlockStartShorthand());
         case CSSPropertyBorderBlockStyle:
             return getCSSPropertyValuesFor2SidesShorthand(borderBlockStyleShorthand());
@@ -4059 +4055 @@
         case CSSPropertyBorderInlineColor:
             return getCSSPropertyValuesFor2SidesShorthand(borderInlineColorShorthand());
-        case CSSPropertyBorderInlineEnd:
-            return getCSSPropertyValuesForShorthandProperties(borderInlineEndShorthand());
-        case CSSPropertyBorderInlineStart:
-            return getCSSPropertyValuesForShorthandProperties(borderInlineStartShorthand());
         case CSSPropertyBorderInlineStyle:
             return getCSSPropertyValuesFor2SidesShorthand(borderInlineStyleShorthand());
@@ -4214 +4206 @@
 
         /* Directional properties are resolved by resolveDirectionAwareProperty() before the switch. */
+        case CSSPropertyBorderBlockEnd:
         case CSSPropertyBorderBlockEndColor:
         case CSSPropertyBorderBlockEndStyle:
         case CSSPropertyBorderBlockEndWidth:
+        case CSSPropertyBorderBlockStart:
         case CSSPropertyBorderBlockStartColor:
         case CSSPropertyBorderBlockStartStyle:
         case CSSPropertyBorderBlockStartWidth:
-        case CSSPropertyBorderEndEndRadius:
-        case CSSPropertyBorderEndStartRadius:
+        case CSSPropertyBorderEndEndRadius:        
+        case CSSPropertyBorderEndStartRadius:        
+        case CSSPropertyBorderInlineEnd:
         case CSSPropertyBorderInlineEndColor:
         case CSSPropertyBorderInlineEndStyle:
         case CSSPropertyBorderInlineEndWidth:
+        case CSSPropertyBorderInlineStart:
         case CSSPropertyBorderInlineStartColor:
         case CSSPropertyBorderInlineStartStyle: